Fix keyboard activation of the voice input mode microphone button - #328768
Draft
meganrogge with Copilot wants to merge 2 commits into
Draft
Fix keyboard activation of the voice input mode microphone button#328768meganrogge with Copilot wants to merge 2 commits into
meganrogge with Copilot wants to merge 2 commits into
Conversation
…n cells Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix keyboard controls for fancy animated button
Fix keyboard activation of the voice input mode microphone button
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The segmented voice input mode control (dictation / voice / listen cells) could not be started or stopped with the keyboard: focusing a cell and pressing Enter/Space did nothing.
Root cause: the cells are
<button>elements inside a toolbar'sActionBar. The ActionBar'sKEY_DOWNhandler intercepts Enter/Space, runs the item's action — the no-op placeholderChatVoiceInputModeAction.run()— and callspreventDefault()/stopPropagation(), swallowing the native button activation before the cell's own gesture can run. (This also produced the two focus stops testers observed: the ActionBar action-item and the inner button.)Change (
voiceInputModeActionViewItem.ts):_registerActivationKeys(cell, handler)— an Enter/SpaceKEY_DOWNlistener that stops the event before it reaches the ActionBar and invokes the same handler as the click gesture._onClickDictation, voice →_onClickVoicePowerToggle, listen →_onClickListen.Enter/Space now activate the focused cell, complementing the existing keybindings. Mouse/pointer and hold-to-talk behavior are unchanged.