Skip to content

Add os-theme to .moduleignore as it's not used by the CLI#321713

Merged
DonJayamanne merged 3 commits into
mainfrom
don/occupational-zebra
Jun 17, 2026
Merged

Add os-theme to .moduleignore as it's not used by the CLI#321713
DonJayamanne merged 3 commits into
mainfrom
don/occupational-zebra

Conversation

@DonJayamanne

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings June 17, 2026 02:58
@DonJayamanne DonJayamanne self-assigned this Jun 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates VS Code’s build-time node_modules pruning rules to exclude the @os-theme/* optional native packages that are pulled in transitively by @github/copilot, since the remote/CLI runtime does not use that native addon.

Changes:

  • Add @os-theme/** to build/.moduleignore with context linking to the tracked engineering issue.
Show a summary per file
File Description
build/.moduleignore Excludes @os-theme/* optional native packages from packaged dependencies to reduce unnecessary native artifacts in the CLI/runtime.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@DonJayamanne DonJayamanne marked this pull request as ready for review June 17, 2026 04:22
@DonJayamanne DonJayamanne enabled auto-merge (squash) June 17, 2026 04:23
@DonJayamanne DonJayamanne merged commit 40fb82c into main Jun 17, 2026
51 checks passed
@DonJayamanne DonJayamanne deleted the don/occupational-zebra branch June 17, 2026 04:26
@vs-code-engineering vs-code-engineering Bot added this to the 1.126.0 milestone Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants