Fix Linux sanity UI test for Restricted-Mode-first workspace trust flow#321708
Draft
Copilot wants to merge 2 commits into
Draft
Fix Linux sanity UI test for Restricted-Mode-first workspace trust flow#321708Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: dmitrivMS <9581278+dmitrivMS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix workspace trust dialog issue in Linux sanity tests
Fix Linux sanity UI test for Restricted-Mode-first workspace trust flow
Jun 17, 2026
rwoll
reviewed
Jun 17, 2026
| this.context.log('Granting workspace trust'); | ||
| await this.runCommand(page, 'Workspaces: Manage Workspace Trust'); | ||
| const trustButton = page.locator('.workspace-trust-buttons .monaco-button', { hasText: /^Trust$/ }).first(); | ||
| await trustButton.click(); |
Member
There was a problem hiding this comment.
@copilot you will then need to click the "Close Modal Editor" to save it.
Contributor
There was a problem hiding this comment.
Clicking Trust does not close the dialog?
Member
There was a problem hiding this comment.
No, the Manage Trust full UI is different than the Modal.
@copilot - you will need to click "Close Modal Editor" (that's the hover text) after clicking the Trust button.
Copilot stopped work on behalf of
rwoll due to an error
June 17, 2026 03:31
Copilot stopped work on behalf of
rwoll due to an error
June 17, 2026 03:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since untrusted workspaces now open directly in Restricted Mode (
workspace.trust.startupPromptdefaults to'never'), the modal workspace-trust dialog is no longer shown on startup. The sanity UI harness still waited for the modal's "Yes, I trust the authors" button, sodesktop-linux-x64andserver-web-linux-x64timed out after 180s.Updated
test/sanity/src/uiTest.tsto grant trust via the new affordance instead of the removed modal:dismissWorkspaceTrustDialog(waited for the modal button) withgrantWorkspaceTrust.grantWorkspaceTrustruns theWorkspaces: Manage Workspace Trustcommand and clicks the Trust button in the workspace trust editor.