Allow interactive commands in macOS agent sandbox#321683
Open
dileepyavan wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the sandbox config generation in TerminalSandboxEngine to allow interactive terminal commands on macOS by enabling PTY support by default, while preserving the ability for advanced runtime settings to explicitly disable it (allowPty: false). It also adds regression tests to ensure the default behavior is macOS-only.
Changes:
- Enable
allowPtyby default for macOS sandbox configs (without overriding explicit runtime settings). - Add tests covering: macOS default
allowPty: true, Linux default not settingallowPty, and macOS explicit override tofalse.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/sandbox/common/terminalSandboxEngine.ts | Sets allowPty to true by default on macOS when generating non-Windows sandbox configs, while respecting explicit overrides. |
| src/vs/platform/sandbox/test/common/terminalSandboxEngine.test.ts | Adds regression tests verifying the macOS-only default and explicit override behavior. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Yoyokrazy
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowPty: falseadvanced runtime overrideTesting
npm run eslint -- src/vs/platform/sandbox/common/terminalSandboxEngine.ts src/vs/platform/sandbox/test/common/terminalSandboxEngine.test.tsnpm run transpile-clientnpm run test-node -- --run src/vs/platform/sandbox/test/common/terminalSandboxEngine.test.ts(28 passing)Fixes #316978