Fix agent host client tool defaults#321617
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts the default allowlist for chat.agentHost.clientTools so that tools that have moved to server-side execution in the agent host are no longer exposed as client-provided tools, and it adds an Agents Window-specific default that omits tools unavailable in that surface.
Changes:
- Refactors the
chat.agentHost.clientToolsdefault into shared constants and removes the feedback/comment tools from the default allowlist. - Adds an
agentsWindowconfiguration default that excludesproblemsandrunTestswhile keeping task and browser client tools.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts | Updates the chat.agentHost.clientTools configuration defaults and introduces an Agents Window-specific default list. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
d971ba2 to
0123ed6
Compare
sandy081
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the agent host client tool defaults so tools that now run server-side in the agent host are no longer exposed as client-provided tools.
Summary:
chat.agentHost.clientToolsallowlist.problemsandrunTests, which are not available there.Validation:
npm run compile-check-ts-native