Skip to content

Fix agent host client tool defaults#321617

Merged
benibenj merged 1 commit into
mainfrom
fix-agent-host-client-tools-defaults
Jun 17, 2026
Merged

Fix agent host client tool defaults#321617
benibenj merged 1 commit into
mainfrom
fix-agent-host-client-tools-defaults

Conversation

@benibenj

Copy link
Copy Markdown
Contributor

This updates the agent host client tool defaults so tools that now run server-side in the agent host are no longer exposed as client-provided tools.

Summary:

  • Remove feedback/comment tools from the default chat.agentHost.clientTools allowlist.
  • Add an Agents Window-specific default that excludes problems and runTests, which are not available there.
  • Keep task and browser client tools available where applicable.

Validation:

  • npm run compile-check-ts-native

Copilot AI review requested due to automatic review settings June 16, 2026 14:25
@benibenj benibenj enabled auto-merge (squash) June 16, 2026 14:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adjusts the default allowlist for chat.agentHost.clientTools so that tools that have moved to server-side execution in the agent host are no longer exposed as client-provided tools, and it adds an Agents Window-specific default that omits tools unavailable in that surface.

Changes:

  • Refactors the chat.agentHost.clientTools default into shared constants and removes the feedback/comment tools from the default allowlist.
  • Adds an agentsWindow configuration default that excludes problems and runTests while keeping task and browser client tools.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts Updates the chat.agentHost.clientTools configuration defaults and introduces an Agents Window-specific default list.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@benibenj benibenj force-pushed the fix-agent-host-client-tools-defaults branch from d971ba2 to 0123ed6 Compare June 16, 2026 14:33
@benibenj benibenj merged commit 77fc09b into main Jun 17, 2026
52 of 55 checks passed
@benibenj benibenj deleted the fix-agent-host-client-tools-defaults branch June 17, 2026 08:25
@vs-code-engineering vs-code-engineering Bot added this to the 1.126.0 milestone Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants