Skip to content

Cover invalid semver debugger worker URL branch #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EmmaYuan1015 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cover invalid semver debugger worker URL branch #2791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9489348
test: cover invalid semver debugger worker URL branch
EmmaYuan1015 Jul 3, 2026
1e9a7ff
Merge branch 'master' into script-importer-invalid-semver-debugger-ui
EmmaYuan1015 Jul 14, 2026
8873bf9
Merge branch 'master' into script-importer-invalid-semver-debugger-ui
EmmaYuan1015 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/debugger/appWorker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,12 @@ suite("appWorker", function () {
"http://localhost:8081/debugger-ui/debuggerWorker.js",
);
});
test("prepareDebuggerWorkerURL should return debugger-ui URL for invalid RN versions", () => {
assert.strictEqual(
scriptImporter.prepareDebuggerWorkerURL("not-a-semver"),
"http://localhost:8081/debugger-ui/debuggerWorker.js",
);
});
test("prepareDebuggerWorkerURL should return correct URL when debuggerWorkerUrlPath is used", () => {
assert.strictEqual(
scriptImporter.prepareDebuggerWorkerURL("0.55.4", ""),
Expand Down
7 changes: 7 additions & 0 deletions test/debugger/scriptImporter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ suite("scriptImporter", function () {
);
});

test("returns the debugger UI worker URL for invalid RN versions", function () {
assert.strictEqual(
scriptImporter.prepareDebuggerWorkerURL("not-a-semver"),
"http://localhost:8081/debugger-ui/debuggerWorker.js",
);
});

test("uses the explicit debugger worker URL path when provided", function () {
assert.strictEqual(
scriptImporter.prepareDebuggerWorkerURL("0.55.4", ""),
Expand Down