-
Notifications
You must be signed in to change notification settings - Fork 282
bugfix/package-name-resolver-for-android-outdated #2473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
bugfix/package-name-resolver-for-android-outdated #2473
Conversation
Package resolver should not depend on the package value from `AndroidManifest.xml` anymore, the latest android app configuration enforce adding the package name in app/build.gradle as `applicationId` Made following changes to deal with the issue: - Fixed package resolver code to detect applicationId in the app/build.gradle file before fallback to android manifest version - Added basic tests to verify the same changes
|
@microsoft-github-policy-service agree |
|
@ConnorQi01 Please review the PR. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@GAM3RG33K This usually happens when test files are executed outside of a proper test environment, so globals like describe are unavailable
Suggestions:
Feel free to share your runTest.js or config details if you need further help debugging this. |
|
@ConnorQi01 Thanks for the detailed instructions about the tests... I have fixed it, Please review the PR again. |
Package resolver should not depend on the package value from
AndroidManifest.xmlanymore, the latest android app configuration enforce adding the package name in app/build.gradle asapplicationId.Check latest documentation: https://developer.android.com/build/configure-app-module#set-application-id
Made following changes to deal with the issue: