Skip to content

Conversation

@inochisa
Copy link

@inochisa inochisa commented Dec 25, 2025

As this extension uses an internal Jedi LSP, it is hard for the users to change the jedi setting to adapt various requirements. And in some cases, the user require a specific version of the Jedi, which is hard to change as it is embedded.

Add a new configuration property to allow the users to use Jedi LSP in their system environment or virtual environments, and auto fallback to the internal version if the external version is not found.

fixes: #25722

@inochisa
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Member

@eleanorjboyd eleanorjboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Would be great to get a test for this item and then otherwise a few comments if you could address. Additionally linting is failing if you could get that fixed too- thanks!

@eleanorjboyd eleanorjboyd added the feature-request Request for new features or functionality label Jan 8, 2026
@eleanorjboyd
Copy link
Member

One other question, did you have an issue regarding this feature? We link an issue to track status and the issue usually outlines the problem and steps to reproduce for tracking. I can make one if not

@eleanorjboyd eleanorjboyd added the info-needed Issue requires more information from poster label Jan 8, 2026
@inochisa
Copy link
Author

inochisa commented Jan 9, 2026

Thanks for the PR! Would be great to get a test for this item and then otherwise a few comments if you could address.

I would like to, for the test, I should take a look to see if there is a good way for it.

Additionally linting is failing if you could get that fixed too- thanks!

That's my fault, I forgot to run prettier.

@inochisa
Copy link
Author

inochisa commented Jan 9, 2026

One other question, did you have an issue regarding this feature? We link an issue to track status and the issue usually outlines the problem and steps to reproduce for tracking. I can make one if not

In fact, there is no direct issue for this, but I got a reminder when I raise the issue davidhalter/jedi#2084, as there is no way for me to test the change.

…vironments

As this extension uses an internal Jedi LSP, it is hard for the users to
change the jedi setting to adapt various requirements. And in some cases,
the user require a specific version of the Jedi, which is hard to change
as it is embedded.

Add a new configuration property to allow the users to use Jedi LSP in
their system environment or virtual environments, and auto fallback to
the internal version if the external version is not found.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
@inochisa
Copy link
Author

Thanks for the PR! Would be great to get a test for this item and then otherwise a few comments if you could address.

I would like to, for the test, I should take a look to see if there is a good way for it.

Any suggestion for the test? I have no idea for this PR as it is very simple. It is just add a new variable and chained to the script.

@inochisa
Copy link
Author

@eleanorjboyd I also change the key to the python.jedi.useJediInEnvPath, as previous key python.languageServer.useJediInEnvPath is broken after rebasing to main branch. Any idea for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality info-needed Issue requires more information from poster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to use Jedi language server in system environment or virtual environments

3 participants