Repository navigation
Fix npm release network isolation - #1987
Eduardo Villalpando Mello (edvilme) wants to merge 1 commit into
Conversation
Allow GitHub and Node tooling through the supported 1ES policy setting while retaining the Preferred baseline and enforced restrictions. Configure the authenticated npm mirror in the release job as well as the build job. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7992926e-a6ef-49ad-b6c9-120b52c0de51
There was a problem hiding this comment.
🔵 Needs a closer look
External Azure template dependencies and denied preview/build permissions leave compatibility, feed authentication, and network access unverified, requiring an authorized pipeline owner to validate before publication.
No open issues 🎉
What changed in this PR
Updates the npm release pipeline to support required network access while retaining network isolation, publication approvals, and artifact validation.
Changes:
- Sets the network isolation policy to
Preferred,GitHub,NodeTool. - Reuses the shared setup template in the publish job to configure Node and the authenticated Azure Artifacts npm registry.
Live pipeline validation remains pending because preview and queue permissions were unavailable.
| File | Description |
|---|---|
build/azure-pipeline.npm.yml |
Configures the network isolation policy and authenticated npm setup for publication. |
Review effort: Balanced
|
Added no-merge, will do a dry-run before merging. |
|
🔒 Automated review in progress — Stella Huang (@StellaHuang95) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman CLI is not installed or is not on PATH. Test runs: none recorded. |
Stella Huang (StellaHuang95)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Summary
Preferred,GitHub,NodeToolnetwork isolation policy so checkout, GitHub API provenance checks, and Node installation have the access they require.Validation
git diff --checkpassed.EditBuildpermission; live pipeline validation is still required.quality=stable,publishPackage=false) was also denied because the account lacksQueue buildspermission. No validation run was started.Release follow-up
This changes only pipeline YAML, so the existing
api/package.jsonpath filter will not trigger publication automatically. After validation and merge, queue a new official run at the fixed main commit withquality=stableandpublishPackage=true. Do not retry the old failed run with its original YAML. The checkout failure did not publish npm 1.8.0, so no additional package version bump is needed.