Skip to content

Fix npm release network isolation - #1987

Open
Eduardo Villalpando Mello (edvilme) wants to merge 1 commit into
mainfrom
fix/npm-network-isolation
Open

Eduardo Villalpando Mello (edvilme) wants to merge 1 commit into
mainfrom
fix/npm-network-isolation

Conversation

@edvilme

@edvilme Eduardo Villalpando Mello (edvilme) commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Select the supported Preferred,GitHub,NodeTool network isolation policy so checkout, GitHub API provenance checks, and Node installation have the access they require.
  • Keep network isolation enforced and preserve existing publication approvals and artifact validation.
  • Reuse the existing authenticated Azure Artifacts npm setup in the publish job, avoiding dependency installation directly from the public npm registry.

Validation

  • YAML structure and manual build-only default verified.
  • Prettier and git diff --check passed.
  • Lint and TypeScript compilation passed.
  • Unit tests: 3,511 passing, 9 pending (Node 22.21.1).
  • Azure server-side YAML override preview was denied because the account lacks the pipeline's EditBuild permission; live pipeline validation is still required.
  • A fresh build-only run (quality=stable, publishPackage=false) was also denied because the account lacks Queue builds permission. No validation run was started.

Release follow-up

This changes only pipeline YAML, so the existing api/package.json path filter will not trigger publication automatically. After validation and merge, queue a new official run at the fixed main commit with quality=stable and publishPackage=true. Do not retry the old failed run with its original YAML. The checkout failure did not publish npm 1.8.0, so no additional package version bump is needed.

Allow GitHub and Node tooling through the supported 1ES policy setting while retaining the Preferred baseline and enforced restrictions. Configure the authenticated npm mirror in the release job as well as the build job.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7992926e-a6ef-49ad-b6c9-120b52c0de51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

External Azure template dependencies and denied preview/build permissions leave compatibility, feed authentication, and network access unverified, requiring an authorized pipeline owner to validate before publication.

No open issues 🎉

What changed in this PR

Updates the npm release pipeline to support required network access while retaining network isolation, publication approvals, and artifact validation.

Changes:

  • Sets the network isolation policy to Preferred,GitHub,NodeTool.
  • Reuses the shared setup template in the publish job to configure Node and the authenticated Azure Artifacts npm registry.

Live pipeline validation remains pending because preview and queue permissions were unavailable.

File Description
build/​azure-pipeline.npm.yml Configures the network isolation policy and authenticated npm setup for publication.

Review effort: Balanced

@edvilme Eduardo Villalpando Mello (edvilme) added the no-merge PR is currently blocked from merging label Nov 5, 2026
@edvilme

Copy link
Copy Markdown
Contributor Author

Added no-merge, will do a dry-run before merging.

@StellaHuang95

Stella Huang (StellaHuang95) commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

🔒 Automated review in progress — Stella Huang (@StellaHuang95) is auto-reviewing this PR.

@StellaHuang95

Copy link
Copy Markdown
Contributor

Reviewed commit: 7b55ea8898889e9437120781b882ecf932f2eedc

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman CLI is not installed or is not on PATH.

Test runs: none recorded.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@StellaHuang95 Stella Huang (StellaHuang95) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 5, 2026

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug no-merge PR is currently blocked from merging review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants