Skip to content

Use shared Python version check action - #1980

Merged
Eduardo Villalpando Mello (edvilme) merged 1 commit into
mainfrom
shared-python-version-action
Nov 4, 2026
Merged

Eduardo Villalpando Mello (edvilme) merged 1 commit into
mainfrom
shared-python-version-action

Conversation

@edvilme

Copy link
Copy Markdown
Contributor

Summary

  • Replace the duplicated weekly Python version checker and shell issue-creation steps with the shared action from microsoft/pylance-engineering#4, pinned to a81ceb5dc25ea56bd0c957ccda3a48886682faea.
  • Supply explicit workflow paths and Python matrix keys.
  • Preserve the Monday schedule, manual dispatch, checkout pin, repository-owner guard, permissions, concurrency, and debt / python-version issue labels.
  • Remove the obsolete local checker and its tests; the shared action owns the implementation and unit tests.

Validation

  • Prettier passes for the changed workflow; YAML parsing and git diff --check pass.
  • Exercised the pinned checker in check-only mode against the actual configured workflows using Python.org release data.
  • Verified coverage matches the previous checker across all seven migrations: 14 workflows and 19 explicit matrices.
  • Verified issue creation arguments, repository, labels, and token forwarding with a mocked subprocess. No live issues were created.
  • The shared action's post-merge CI passed.

Behavior change

The shared action intentionally defers duplicate-issue detection. Issue creation remains enabled, so each scheduled/manual run with missing coverage creates an issue even if one already exists or was previously closed. Concurrency prevents overlapping runs, not duplicates across runs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 956d3afd-ae0b-486c-a60c-3a6276c23213
@edvilme Eduardo Villalpando Mello (edvilme) added the debt Code quality issues label Nov 4, 2026
@bschnurr

Bill Schnurr (bschnurr) commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@bschnurr

Copy link
Copy Markdown
Member

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "9d682d37f258423af1f9a519212134e05a55a4a97f247345b7ee400c78918047": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@edvilme
Eduardo Villalpando Mello (edvilme) merged commit bc639de into main Nov 4, 2026
117 of 119 checks passed
@edvilme
Eduardo Villalpando Mello (edvilme) deleted the shared-python-version-action branch November 4, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code quality issues review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants