Skip to content

Fix status check deduplication dropping checks from different workflow events#8663

Draft
Copilot wants to merge 3 commits intomainfrom
copilot/fix-extension-pr-checks
Draft

Fix status check deduplication dropping checks from different workflow events#8663
Copilot wants to merge 3 commits intomainfrom
copilot/fix-extension-pr-checks

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

When the same workflow triggers on both push and pull_request, the resulting check runs share the same name but are distinct checks. deduplicateStatusChecks keyed only on context (the check run name), collapsing e.g. 4 checks into 2.

Changes

  • src/github/githubRepository.ts: Include event and workflowName in the deduplication key so checks from different trigger events or different workflows are preserved:

    const key = `${status.context}\0${status.event ?? ''}\0${status.workflowName ?? ''}`;

    Re-runs of the same check (same name + event + workflow) are still correctly deduplicated.

  • src/test/github/githubRepository.test.ts: Added tests covering different events kept separate, same-event deduplication, different workflows kept separate, and pending-over-completed preference.

Copilot AI linked an issue Apr 14, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits April 14, 2026 10:06
Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/588c7904-b943-44bc-842d-b78baf609a0a

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
When the same workflow runs for both push and pull_request events,
checks with the same name but different events were incorrectly merged
during deduplication. Now the deduplication key includes the event
and workflowName fields so distinct checks are preserved.

Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/588c7904-b943-44bc-842d-b78baf609a0a

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix extension not showing all PR checks Fix status check deduplication dropping checks from different workflow events Apr 14, 2026
Copilot AI requested a review from alexr00 April 14, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension does not show all PR checks

2 participants