fix(deps-dev): align VS Code types with engine - #1933
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments; dependency and lockfile updates are aligned.
Pull request overview
Aligns @types/vscode with the extension’s minimum supported VS Code engine version.
Changes:
- Pins
@types/vscodeto1.88.0. - Synchronizes the lockfile version and integrity metadata.
File summaries
| File | Summary |
|---|---|
package.json |
Updates the VS Code type definitions dependency. |
package-lock.json |
Locks the matching package version and checksum. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Changyong Gong (chagong)
approved these changes
Sep 14, 2026
wenyt (wenytang-ms)
deleted the
fix/vscode-types-engine-compatibility
branch
September 14, 2026 03:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@types/vscodeto1.88.0so it matches the minimum supported VS Code engine^1.88.0Root cause
The nightly pre-release build failed during
vsce packagebecause@types/vscode@1.125.0was newer than the extension's declared minimum VS Code engine version.Validation
package.json,package-lock.json, and the installed package all resolve@types/vscode@1.88.0npx @vscode/vsce@latest package --pre-release -o extension.vsix; the original engine/types compatibility check passed and packaging reached the prepublish buildglob@13update; that unrelated issue is intentionally not included in this change