Skip to content

Remove remnants of the recursiveIncludes.reduce option - #14761

Open
Colen Garoutte-Carson (Colengms) wants to merge 1 commit into
mainfrom
dev/coleng/remove_reduce_option
Open

Remove remnants of the recursiveIncludes.reduce option#14761
Colen Garoutte-Carson (Colengms) wants to merge 1 commit into
mainfrom
dev/coleng/remove_reduce_option

Conversation

@Colengms

Copy link
Copy Markdown
Contributor

Removes some lingering remnants of the recursiveIncludes.reduce option

recursiveIncludes.reduce had already been removed from the cpp_properties.json schema. The native process now implements recursive includes in an efficient manner that no longer requires a 'reduce' phase.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Stale localized catalogs still retain removed recursiveIncludes.reduce entries.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 2 Low severity

New issues introduced by this change (2)
Severity Finding
Low severity Extension/​package.nls.json — Remove the obsolete option from localized message catalogs
Low severity Extension/​ui/​settings.html — Remove obsolete recursive-reduce UI translations
What changed in this PR

Removes the obsolete recursiveIncludes.reduce option from the extension UI, configuration typings, and package metadata.

Changes:

  • Removes the settings UI control.
  • Removes the TypeScript configuration property.
  • Removes the contributed setting and English localization entry.
  • Notes stale entries remaining in localized catalogs.
File Reviewed change
Extension/​ui/​settings.html Removes the obsolete settings UI; localized UI tables still contain stale IDs.
Extension/​src/​LanguageServer/​configurations.ts Removes the configuration property.
Extension/​package.nls.json Removes the English localization entry; localized catalogs still contain the obsolete key.
Extension/​package.json Removes the contributed setting schema.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Extension/package.nls.json
Comment thread Extension/ui/settings.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pull Request

Development

Successfully merging this pull request may close these issues.

2 participants