Skip to content

Fix esbuild lockfile resolution#333

Draft
anderson-joyle wants to merge 2 commits into
mainfrom
copilot/pr318-esbuild-lockfile-fix-20260708
Draft

Fix esbuild lockfile resolution#333
anderson-joyle wants to merge 2 commits into
mainfrom
copilot/pr318-esbuild-lockfile-fix-20260708

Conversation

@anderson-joyle

@anderson-joyle anderson-joyle commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • carries forward the dependency updates from Dependabot PR Bump the all-dependencies group across 3 directories with 10 updates #318
  • regenerates src/vscode-extensions/package-lock.json so esbuild and all @esbuild/* optional packages resolve to 0.28.1
  • fixes the npm ci lockfile mismatch caused by package.json requiring esbuild@0.28.1 while the lockfile still resolved 0.28.0

Validation

  • npm ci passes after the lockfile update
  • npm audit no longer reports the esbuild advisory; one existing moderate brace-expansion advisory remains
  • npm run compile-tests passes
  • npm run compile passes
  • npm run lint passes
  • dotnet build src\build.proj --configuration Debug -p:langversion=preview passes with 0 warnings/errors
  • dotnet test src\build.proj --no-build --no-restore --configuration Debug passes: 1347 passed, 9 skipped

Notes

  • Full npm test remains blocked in the VS Code host-test phase: @vscode/test-electron downloads VS Code 1.128.0, then Electron fails to load workbench.html from the extracted archive and hangs. The pretest portion of npm test completed successfully before that blocker.

Copilot AI review requested due to automatic review settings July 8, 2026 18:52
Copilot AI reviewed Jul 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates VS Code extension workspace dependencies to resolve an npm ci lockfile mismatch and ensure esbuild optional binaries consistently resolve to 0.28.1, aligning the workspace lockfiles with the dependency intent and the Dependabot updates referenced in PR #318.

Changes:

  • Bump esbuild to 0.28.1 in the extension package and regenerate the workspace lockfile so all @esbuild/* optional packages resolve to 0.28.1.
  • Update shared’s yargs devDependency to ^17.7.3 and refresh its lockfile accordingly.
  • Refresh src/vscode-extensions/package-lock.json to carry forward transitive updates (e.g., @vscode/extension-telemetry, eslint, nerdbank-gitversioning, semver) consistent with PR #318.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
src/vscode-extensions/shared/package.json Bumps yargs devDependency to ^17.7.3.
src/vscode-extensions/shared/package-lock.json Updates resolved yargs to 17.7.3 (and normalizes the lockfile header).
src/vscode-extensions/package-lock.json Regenerates workspace lockfile so esbuild/@esbuild/* resolve to 0.28.1 and carries forward related transitive updates.
src/vscode-extensions/microsoft-powerplatformlang-extension/package.json Pins esbuild to 0.28.1 to match the regenerated lockfile.
Files not reviewed (2)
  • src/vscode-extensions/package-lock.json: Generated file
  • src/vscode-extensions/shared/package-lock.json: Generated file

Copilot AI review requested due to automatic review settings July 13, 2026 15:13
@anderson-joyle
anderson-joyle force-pushed the copilot/pr318-esbuild-lockfile-fix-20260708 branch from 3ead066 to 4af3a31 Compare July 13, 2026 15:13
Copilot AI reviewed Jul 13, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.

Files not reviewed (2)
  • src/vscode-extensions/package-lock.json: Generated file
  • src/vscode-extensions/shared/package-lock.json: Generated file

dependabot Bot and others added 2 commits July 16, 2026 18:16
@dependabot @anderson-joyle
Bump the all-dependencies group across 3 directories with 10 updates
6dfbe9f 
Bumps the all-dependencies group with 10 updates in the /src/vscode-extensions directory:

| Package | From | To |
| --- | --- | --- |
| [@vscode/extension-telemetry](https://github.com/Microsoft/vscode-extension-telemetry) | `1.5.1` | `1.5.2` |
| [semver](https://github.com/npm/node-semver) | `7.7.4` | `7.8.5` |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `22.19.18` | `22.20.1` |
| [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode) | `1.118.0` | `1.125.0` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `8.59.2` | `8.63.0` |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `8.59.2` | `8.63.0` |
| [esbuild](https://github.com/evanw/esbuild) | `0.28.0` | `0.28.1` |
| [eslint](https://github.com/eslint/eslint) | `10.3.0` | `10.6.0` |
| [nerdbank-gitversioning](https://github.com/dotnet/Nerdbank.GitVersioning) | `3.9.50` | `3.10.85` |
| [yargs](https://github.com/yargs/yargs) | `17.7.2` | `17.7.3` |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `22.19.18` | `22.20.1` |
| [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode) | `1.118.0` | `1.125.0` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `8.59.2` | `8.63.0` |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `8.59.2` | `8.63.0` |
| [esbuild](https://github.com/evanw/esbuild) | `0.28.0` | `0.28.1` |

Bumps the all-dependencies group with 1 update in the /src/vscode-extensions/microsoft-powerplatformlang-extension directory: [esbuild](https://github.com/evanw/esbuild).
Bumps the all-dependencies group with 1 update in the /src/vscode-extensions/shared directory: [yargs](https://github.com/yargs/yargs).


Updates `@vscode/extension-telemetry` from 1.5.1 to 1.5.2
- [Release notes](https://github.com/Microsoft/vscode-extension-telemetry/releases)
- [Commits](microsoft/vscode-extension-telemetry@v1.5.1...v1.5.2)

Updates `semver` from 7.7.4 to 7.8.5
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.7.4...v7.8.5)

Updates `@types/node` from 22.19.18 to 22.20.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `@types/vscode` from 1.118.0 to 1.125.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode)

Updates `@typescript-eslint/eslint-plugin` from 8.59.2 to 8.63.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.63.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.59.2 to 8.63.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.63.0/packages/parser)

Updates `esbuild` from 0.28.0 to 0.28.1
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.28.0...v0.28.1)

Updates `eslint` from 10.3.0 to 10.6.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v10.3.0...v10.6.0)

Updates `nerdbank-gitversioning` from 3.9.50 to 3.10.85
- [Release notes](https://github.com/dotnet/Nerdbank.GitVersioning/releases)
- [Commits](dotnet/Nerdbank.GitVersioning@v3.9.50...v3.10.85)

Updates `yargs` from 17.7.2 to 17.7.3
- [Release notes](https://github.com/yargs/yargs/releases)
- [Changelog](https://github.com/yargs/yargs/blob/main/CHANGELOG.md)
- [Commits](yargs/yargs@v17.7.2...v17.7.3)

Updates `@vscode/extension-telemetry` from 1.5.1 to 1.5.2
- [Release notes](https://github.com/Microsoft/vscode-extension-telemetry/releases)
- [Commits](microsoft/vscode-extension-telemetry@v1.5.1...v1.5.2)

Updates `semver` from 7.7.4 to 7.8.5
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.7.4...v7.8.5)

Updates `@types/node` from 22.19.18 to 22.20.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `@types/vscode` from 1.118.0 to 1.125.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode)

Updates `@typescript-eslint/eslint-plugin` from 8.59.2 to 8.63.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.63.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.59.2 to 8.63.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.63.0/packages/parser)

Updates `esbuild` from 0.28.0 to 0.28.1
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.28.0...v0.28.1)

Updates `eslint` from 10.3.0 to 10.6.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v10.3.0...v10.6.0)

Updates `nerdbank-gitversioning` from 3.9.50 to 3.10.85
- [Release notes](https://github.com/dotnet/Nerdbank.GitVersioning/releases)
- [Commits](dotnet/Nerdbank.GitVersioning@v3.9.50...v3.10.85)

Updates `yargs` from 17.7.2 to 17.7.3
- [Release notes](https://github.com/yargs/yargs/releases)
- [Changelog](https://github.com/yargs/yargs/blob/main/CHANGELOG.md)
- [Commits](yargs/yargs@v17.7.2...v17.7.3)

Updates `esbuild` from 0.28.0 to 0.28.1
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.28.0...v0.28.1)

Updates `esbuild` from 0.28.0 to 0.28.1
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.28.0...v0.28.1)

Updates `yargs` from 17.7.2 to 17.7.3
- [Release notes](https://github.com/yargs/yargs/releases)
- [Changelog](https://github.com/yargs/yargs/blob/main/CHANGELOG.md)
- [Commits](yargs/yargs@v17.7.2...v17.7.3)

Updates `yargs` from 17.7.2 to 17.7.3
- [Release notes](https://github.com/yargs/yargs/releases)
- [Changelog](https://github.com/yargs/yargs/blob/main/CHANGELOG.md)
- [Commits](yargs/yargs@v17.7.2...v17.7.3)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 22.20.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: "@types/node"
  dependency-version: 22.20.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: "@types/vscode"
  dependency-version: 1.125.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: "@types/vscode"
  dependency-version: 1.125.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-version: 8.62.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-version: 8.62.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: "@typescript-eslint/parser"
  dependency-version: 8.62.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: "@typescript-eslint/parser"
  dependency-version: 8.62.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: "@vscode/extension-telemetry"
  dependency-version: 1.5.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: "@vscode/extension-telemetry"
  dependency-version: 1.5.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: esbuild
  dependency-version: 0.28.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: esbuild
  dependency-version: 0.28.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: esbuild
  dependency-version: 0.28.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: esbuild
  dependency-version: 0.28.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: eslint
  dependency-version: 10.6.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: eslint
  dependency-version: 10.6.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: nerdbank-gitversioning
  dependency-version: 3.10.85
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: nerdbank-gitversioning
  dependency-version: 3.10.85
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: semver
  dependency-version: 7.8.5
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: semver
  dependency-version: 7.8.5
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: yargs
  dependency-version: 17.7.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: yargs
  dependency-version: 17.7.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: yargs
  dependency-version: 17.7.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: yargs
  dependency-version: 17.7.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@anderson-joyle
Fix esbuild lockfile resolution
80635cd 
Regenerate the vscode-extensions workspace lockfile so esbuild and its optional platform packages resolve to 0.28.1, matching the extension package manifest.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 16, 2026 21:16
@anderson-joyle
anderson-joyle force-pushed the copilot/pr318-esbuild-lockfile-fix-20260708 branch from 4af3a31 to 80635cd Compare July 16, 2026 21:16
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • src/vscode-extensions/package-lock.json: Generated file
  • src/vscode-extensions/shared/package-lock.json: Generated file

Comment thread src/vscode-extensions/package-lock.json
Comment on lines +593 to +597
"microsoft-powerplatformlang-extension/node_modules/nerdbank-gitversioning": {
"version": "3.10.85",
"integrity": "sha512-FTSiJH8drAlbFDm7/QVcnp+Kshir41zKjJ+x60tNaHnx2YWsVnvzkywRJ/fvDjE6LjHZ5Xk9IVLb1mebWu5P8A==",
"dev": true,
"bin": {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anderson-joyle