Visualize running container counts on tree root and group nodes#492
Open
SATYAM-PRATIBHAN wants to merge 3 commits into
Open
Visualize running container counts on tree root and group nodes#492SATYAM-PRATIBHAN wants to merge 3 commits into
SATYAM-PRATIBHAN wants to merge 3 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
bwateratmsft
self-requested a review
May 28, 2026 19:10
Collaborator
|
@fiveisprime / @SATYAM-PRATIBHAN what do you think about only showing this additional description if there are non-running containers? i.e. less than 100% running |
bwateratmsft
requested changes
Jul 23, 2026
bwateratmsft
left a comment
bwateratmsft
left a comment
Collaborator
There was a problem hiding this comment.
Can you also include a screenshot of the label on the Containers root?
| private _cachedItems: TItem[] | undefined; | ||
| private _currentDockerStatus: DockerStatus; | ||
|
|
||
| protected get currentItems(): TItem[] | undefined { |
Collaborator
There was a problem hiding this comment.
To protect against mistakes, I'd do:
Suggested change
| protected get currentItems(): TItem[] | undefined { | |
| protected get currentItems(): Readonly<TItem[]> | undefined { |
Or maybe there's ReadonlyArray<TItem>, I can't remember
| private _items: TItem[]; | ||
| private _childTreeItems: AzExtTreeItem[]; | ||
|
|
||
| protected get items(): TItem[] { |
Collaborator
There was a problem hiding this comment.
To protect against mistakes, I'd do:
Suggested change
| protected get items(): TItem[] { | |
| protected get items(): Readonly<TItem[]> { |
Or maybe there's ReadonlyArray<TItem>, I can't remember
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves container visibility in the tree view when nodes are collapsed or grouped, which is especially helpful in environments with many containers.
Dynamic status summaries were added to the description field of the Containers root node and individual container group nodes (such as Docker Compose projects). This makes it possible to see container state at a glance without manually expanding nodes.
Key Changes
(X running)next to the Containers label when one or more containers are active.(X/Y running)next to group names, showing the number of running containers versus the total number of containers in that group.LocalRootTreeItemBaseandLocalGroupTreeItemBaseto safely expose item data to subclasses, enabling these summaries while following existing architectural patterns.src/test/tree/containers/ContainerTreeVisualization.test.tsto verify the description logic for both root and group nodes.Related Issue
Fixes #485
Visuals
Before:
After:
Testing
npm run build:checkpassed successfully.