-
Notifications
You must be signed in to change notification settings - Fork 336
Gate debug logs behind TYPESPEC_DEBUG environment variable with custom implementation #9396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
18
commits into
main
Choose a base branch
from
copilot/fix-lsp-debug-message-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7a783c7
Initial plan
Copilot 8abac89
Add ENABLE_COMPILE_CONFIG_LOGGING environment variable to control deb…
Copilot 9750838
Fix JavaScript hoisting issue with logCompileConfig function
Copilot 94bf93f
Refactor to use Node.js DEBUG pattern instead of individual env vars
Copilot b4bcd2d
Keep original naming convention for debug areas
Copilot 451c4e0
Refactor to use debug npm package and update launch.json comments
Copilot ca30a74
Add documentation comment for ENABLE_LM_LOGGING in launch.json
Copilot 42c1d4f
Refactor typespec-vscode to use debug package for LM logging
Copilot 3b2668f
Remove unnecessary debug variable in language-model.ts
Copilot fa37194
Revert tspconfig completion to use regular log function
Copilot 58fb695
Remove unused logCompileConfig function
Copilot 21ba492
Fix code formatting issues
Copilot 856eeb0
Move debug package to devDependencies in typespec-vscode
Copilot 9757eaf
Replace debug npm package with custom implementation using TYPESPEC_D…
Copilot bb835bb
Move debug code to dedicated debug.ts files
Copilot e0515c1
Merge remote-tracking branch 'origin/main' into copilot/fix-lsp-debug…
Copilot bae6a68
Merge branch 'main' and update ThirdPartyNotices.txt
Copilot f0f7b6e
Add changelog and document why TYPESPEC_DEBUG is used instead of DEBUG
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
.chronus/changes/copilot-fix-lsp-debug-message-issue-2026-1-6-5-49-13.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| changeKind: internal | ||
| packages: | ||
| - "@typespec/compiler" | ||
| - typespec-vscode | ||
| --- | ||
|
|
||
| Gate debug logs behind TYPESPEC_DEBUG environment variable to suppress spam messages during compilation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import { getEnvironmentVariable } from "../utils/misc.js"; | ||
|
|
||
| /** | ||
| * Debug areas that can be enabled via TYPESPEC_DEBUG environment variable. | ||
| * | ||
| * Note: We use TYPESPEC_DEBUG instead of DEBUG because the DEBUG environment variable | ||
| * is not supported in VSCode extensions. See: https://github.com/microsoft/vscode/issues/290140 | ||
| * | ||
| * Usage: TYPESPEC_DEBUG=typespec:server_compile,typespec:compile_config | ||
| * | ||
| * Examples: | ||
| * TYPESPEC_DEBUG=typespec:server_compile - Enable server compilation debug logs | ||
| * TYPESPEC_DEBUG=typespec:* - Enable all typespec debug logs | ||
| * TYPESPEC_DEBUG=typespec:server_compile,typespec:compile_config - Enable multiple areas | ||
| */ | ||
| const debugAreas = { | ||
| serverCompile: "typespec:server_compile", | ||
| updateManager: "typespec:update_manager", | ||
| compileConfig: "typespec:compile_config", | ||
| } as const; | ||
|
|
||
| /** | ||
| * Check if a debug area is enabled via the TYPESPEC_DEBUG environment variable. | ||
| * Supports comma-separated values and wildcards. | ||
| */ | ||
| function isDebugEnabled(area: string): boolean { | ||
| const debug = getEnvironmentVariable("TYPESPEC_DEBUG"); | ||
| if (!debug) { | ||
| return false; | ||
| } | ||
|
|
||
| const areas = debug.split(",").map((a) => a.trim()); | ||
|
|
||
| return areas.some((pattern) => { | ||
| // Exact match | ||
| if (pattern === area) { | ||
| return true; | ||
| } | ||
|
|
||
| // Wildcard pattern matching | ||
| if (pattern.includes("*")) { | ||
| const regexPattern = pattern.replace(/\*/g, ".*"); | ||
| const regex = new RegExp(`^${regexPattern}$`); | ||
| return regex.test(area); | ||
| } | ||
|
|
||
| return false; | ||
| }); | ||
| } | ||
|
|
||
| export const debugLoggers = { | ||
| serverCompile: { enabled: isDebugEnabled(debugAreas.serverCompile) }, | ||
| updateManager: { enabled: isDebugEnabled(debugAreas.updateManager) }, | ||
| compileConfig: { enabled: isDebugEnabled(debugAreas.compileConfig) }, | ||
| } as const; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| export const StartFileName = "main.tsp"; | ||
| export const TspConfigFileName = "tspconfig.yaml"; | ||
| export const EmptyGuid = "00000000-0000-0000-0000-000000000000"; | ||
|
|
||
| export const ENABLE_LM_LOGGING = "ENABLE_LM_LOGGING"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /** | ||
| * Debug logger for Language Model operations. | ||
| * Can be enabled via TYPESPEC_DEBUG environment variable. | ||
| * | ||
| * Note: We use TYPESPEC_DEBUG instead of DEBUG because the DEBUG environment variable | ||
| * is not supported in VSCode extensions. See: https://github.com/microsoft/vscode/issues/290140 | ||
| * | ||
| * Usage: TYPESPEC_DEBUG=typespec:lm | ||
| * | ||
| * Examples: | ||
| * TYPESPEC_DEBUG=typespec:lm - Enable Language Model debug logs | ||
| * TYPESPEC_DEBUG=typespec:* - Enable all typespec debug logs | ||
| */ | ||
| function isDebugEnabled(area: string): boolean { | ||
| const debug = process.env.TYPESPEC_DEBUG; | ||
| if (!debug) { | ||
| return false; | ||
| } | ||
|
|
||
| const areas = debug.split(",").map((a) => a.trim()); | ||
|
|
||
| return areas.some((pattern) => { | ||
| // Exact match | ||
| if (pattern === area) { | ||
| return true; | ||
| } | ||
|
|
||
| // Wildcard pattern matching | ||
| if (pattern.includes("*")) { | ||
| const regexPattern = pattern.replace(/\*/g, ".*"); | ||
| const regex = new RegExp(`^${regexPattern}$`); | ||
| return regex.test(area); | ||
| } | ||
|
|
||
| return false; | ||
| }); | ||
| } | ||
|
|
||
| export const debugLoggers = { | ||
| lm: { enabled: isDebugEnabled("typespec:lm") }, | ||
| } as const; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it looks like
DEBUGwill never work with vscode from the issue coment, do you think we still need thetypespec:prefix?Could the area also try to follow the pattern we have for tracing for consitency(Use
.instead of_)service.compileservice.config