[http-client-csharp] Add repro for model factory namespace loss - #11848
Draft
Wei Hu (live1206) wants to merge 2 commits into
Draft
[http-client-csharp] Add repro for model factory namespace loss#11848Wei Hu (live1206) wants to merge 2 commits into
Wei Hu (live1206) wants to merge 2 commits into
Conversation
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
…actory-repro # Conflicts: # packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/test/Providers/ModelFactories/ModelFactoriesCustomizationTests.cs
commit: |
Contributor
|
No changes needing a change description found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
using ;andglobal::.output is not emittedThis PR intentionally contains only the failing reproduction and remains a draft until the generator fix is added.
Validation
dotnet test packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/test/Microsoft.TypeSpec.Generator.Tests.csproj --filter "FullyQualifiedName~CustomFullConstructorFactoryMethodRetainsGeneratedModelParameterNamespaces" --no-restore— fails as expected because the generated model factory containsusing ;andglobal::.type referencesReproduces #11846