Unify C# model base type provider resolution#11262
Draft
live1206 wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9767d3ab-bcc8-4717-a7a6-d5efb715989b
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
commit: |
Contributor
|
No changes needing a change description found. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9767d3ab-bcc8-4717-a7a6-d5efb715989b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseTypeProviderthe canonical base-provider resolution path for C# modelsBaseModelProviderfrom the resolved provider so the two relationships cannot divergeSystemObjectTypeProviderfallback and use Roslyn-backed providers for external typesSystemObjectModelProvidersupport and generated-model resolutionFixes #11261
Validation
dotnet test packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator.sln --no-restore --nologo --verbosity quietpwsh packages/http-client-csharp/eng/scripts/Generate.ps1npm run coppnpm formatRepository-wide
pnpm lintremains blocked by pre-existing deprecation warnings in unrelated TypeScript packages.