Fix tagMetadata extension diagnostic targets#10776
Open
kiwigitops wants to merge 1 commit into
Open
Conversation
kiwigitops
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl,
timotheeguerin and
witemple-msft
as code owners
kiwigitops
force-pushed
the
fix-openapi-tagmetadata-extension-target
branch
from
8500595 to
2fc1378
Compare
commit: |
| expectDiagnostics(diagnostics, { | ||
| code: "@typespec/openapi/invalid-extension-key", | ||
| message: `OpenAPI extension must start with 'x-' but was 'custom'`, | ||
| }); |
Member
There was a problem hiding this comment.
expectDiagnostics takes in a pos and the actual value can be retrieved if using compileAndDiagnose and using a marker in the code
Contributor
|
All changed packages have been documented.
|
kiwigitops
force-pushed
the
fix-openapi-tagmetadata-extension-target
branch
from
2fc1378 to
85c43b1
Compare
Author
|
Updated: the test now uses |
Signed-off-by: kiwigitops <kiwisclubco@gmail.com>
kiwigitops
force-pushed
the
fix-openapi-tagmetadata-extension-target
branch
from
85c43b1 to
f0bf9be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10767
This keeps the OpenAPI extension-key validation tied to the metadata object literal, so invalid keys such as
customare reported on the offending property instead of the tag name.Verification:
npx pnpm --filter @typespec/openapi buildnpx pnpm --filter @typespec/openapi test -- decorators.test.ts