Bump TCGC to 0.67.1 for http-client-csharp

packages/http-client-csharp/emitter/src/lib/type-converter.ts

@@ -329,7 +329,9 @@ function createEnumType(
     values: values,
     // constantType.access, TODO - constant type now does not have access. TCGC will add it later
     access:
-      sdkType.kind === "enum" ? getAccessOverride(sdkContext, sdkType.__raw as any) : undefined,
+      sdkType.kind === "enum" && sdkType.__raw
+        ? getAccessOverride(sdkContext, sdkType.__raw as any)
+        : undefined,
     namespace: namespace,
     deprecation: sdkType.deprecation,
     summary: sdkType.summary,

packages/http-client-csharp/emitter/src/lib/utils.ts

@@ -234,5 +234,5 @@ export function containsMultiServiceClient(
  * @beta
  */
 export function isMultiServiceClient(client: SdkClientType<SdkHttpOperation>): boolean {
-  return Array.isArray(client.__raw.service) && client.__raw.service.length > 1;
+  return client.__raw.services.length > 1;
 }

packages/http-client-csharp/emitter/test/Unit/client-converter.test.ts

@@ -72,8 +72,8 @@ describe("isMultiServiceClient", () => {
         @client({
           name: "CombinedClient",
           service: [ServiceA, ServiceB],
+          autoMergeService: true,
         })
-        @useDependency(ServiceA.VersionsA.av1, ServiceB.VersionsB.bv2)
         namespace Service.MultiService {}
       `,
       runner,
@@ -210,6 +210,7 @@ describe("isMultiServiceClient", () => {
         @client({
           name: "CombinedClient",
           service: [ServiceA, ServiceB],
+          autoMergeService: true,
         })
 
         namespace Service.MultiService {}
@@ -426,8 +427,8 @@ describe("client name suffix", () => {
         @client({
           name: "Combined",
           service: [ServiceA, ServiceB],
+          autoMergeService: true,
         })
-        @useDependency(ServiceA.VersionsA.av1, ServiceB.VersionsB.bv1)
         namespace Service.MultiService {}
       `,
       runner,

packages/http-client-csharp/emitter/test/Unit/client-model-builder.test.ts

@@ -290,8 +290,8 @@ describe("parseApiVersions", () => {
         @client({
           name: "CombinedClient",
           service: [ServiceA, ServiceB],
+          autoMergeService: true,
         })
-        @useDependency(ServiceA.VersionsA.av1, ServiceB.VersionsB.bv2)
         namespace Service.MultiService {}
       `,
       runner,
@@ -406,6 +406,7 @@ describe("parseApiVersions", () => {
         @client({
           name: "CombinedClient",
           service: [ServiceA, ServiceB],
+          autoMergeService: true,
         })
 
         namespace Service.MultiService {}

packages/http-client-csharp/generator/TestProjects/Local/Sample-TypeSpec/src/Generated/SampleTypeSpecClient.RestClient.cs

@@ -219,14 +219,14 @@ internal PipelineMessage CreateReturnsAnonymousModelRequest(RequestOptions optio
             return message;
         }
 
-        internal PipelineMessage CreateGetUnknownValueRequest(string accept, RequestOptions options)
+        internal PipelineMessage CreateGetUnknownValueRequest(RequestOptions options)
         {
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/unknown-value", false);
             PipelineMessage message = Pipeline.CreateMessage(uri.ToUri(), "GET", PipelineMessageClassifier200);
             PipelineRequest request = message.Request;
-            request.Headers.Set("Accept", accept);
+            request.Headers.Set("Accept", "text/plain");
             message.Apply(options);
             return message;
         }

packages/http-client-csharp/generator/TestProjects/Local/Sample-TypeSpec/src/Generated/SampleTypeSpecClient.cs

@@ -1053,17 +1053,12 @@ public virtual async Task<ClientResult<ReturnsAnonymousModelResponse>> ReturnsAn
         /// </item>
         /// </list>
         /// </summary>
-        /// <param name="accept"></param>
         /// <param name="options"> The request options, which can override default behaviors of the client pipeline on a per-call basis. </param>
-        /// <exception cref="ArgumentNullException"> <paramref name="accept"/> is null. </exception>
-        /// <exception cref="ArgumentException"> <paramref name="accept"/> is an empty string, and was expected to be non-empty. </exception>
         /// <exception cref="ClientResultException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual ClientResult GetUnknownValue(string accept, RequestOptions options)
+        public virtual ClientResult GetUnknownValue(RequestOptions options)
         {
-            Argument.AssertNotNullOrEmpty(accept, nameof(accept));
-
-            using PipelineMessage message = CreateGetUnknownValueRequest(accept, options);
+            using PipelineMessage message = CreateGetUnknownValueRequest(options);
             return ClientResult.FromResponse(Pipeline.ProcessMessage(message, options));
         }
 
@@ -1075,45 +1070,30 @@ public virtual ClientResult GetUnknownValue(string accept, RequestOptions option
         /// </item>
         /// </list>
         /// </summary>
-        /// <param name="accept"></param>
         /// <param name="options"> The request options, which can override default behaviors of the client pipeline on a per-call basis. </param>
-        /// <exception cref="ArgumentNullException"> <paramref name="accept"/> is null. </exception>
-        /// <exception cref="ArgumentException"> <paramref name="accept"/> is an empty string, and was expected to be non-empty. </exception>
         /// <exception cref="ClientResultException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual async Task<ClientResult> GetUnknownValueAsync(string accept, RequestOptions options)
+        public virtual async Task<ClientResult> GetUnknownValueAsync(RequestOptions options)
         {
-            Argument.AssertNotNullOrEmpty(accept, nameof(accept));
-
-            using PipelineMessage message = CreateGetUnknownValueRequest(accept, options);
+            using PipelineMessage message = CreateGetUnknownValueRequest(options);
             return ClientResult.FromResponse(await Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false));
         }
 
         /// <summary> get extensible enum. </summary>
-        /// <param name="accept"></param>
         /// <param name="cancellationToken"> The cancellation token that can be used to cancel the operation. </param>
-        /// <exception cref="ArgumentNullException"> <paramref name="accept"/> is null. </exception>
-        /// <exception cref="ArgumentException"> <paramref name="accept"/> is an empty string, and was expected to be non-empty. </exception>
         /// <exception cref="ClientResultException"> Service returned a non-success status code. </exception>
-        public virtual ClientResult<string> GetUnknownValue(string accept, CancellationToken cancellationToken = default)
+        public virtual ClientResult<string> GetUnknownValue(CancellationToken cancellationToken = default)
         {
-            Argument.AssertNotNullOrEmpty(accept, nameof(accept));
-
-            ClientResult result = GetUnknownValue(accept, cancellationToken.ToRequestOptions());
+            ClientResult result = GetUnknownValue(cancellationToken.ToRequestOptions());
             return ClientResult.FromValue(result.GetRawResponse().Content.ToString(), result.GetRawResponse());
         }
 
         /// <summary> get extensible enum. </summary>
-        /// <param name="accept"></param>
         /// <param name="cancellationToken"> The cancellation token that can be used to cancel the operation. </param>
-        /// <exception cref="ArgumentNullException"> <paramref name="accept"/> is null. </exception>
-        /// <exception cref="ArgumentException"> <paramref name="accept"/> is an empty string, and was expected to be non-empty. </exception>
         /// <exception cref="ClientResultException"> Service returned a non-success status code. </exception>
-        public virtual async Task<ClientResult<string>> GetUnknownValueAsync(string accept, CancellationToken cancellationToken = default)
+        public virtual async Task<ClientResult<string>> GetUnknownValueAsync(CancellationToken cancellationToken = default)
         {
-            Argument.AssertNotNullOrEmpty(accept, nameof(accept));
-
-            ClientResult result = await GetUnknownValueAsync(accept, cancellationToken.ToRequestOptions()).ConfigureAwait(false);
+            ClientResult result = await GetUnknownValueAsync(cancellationToken.ToRequestOptions()).ConfigureAwait(false);
             return ClientResult.FromValue(result.GetRawResponse().Content.ToString(), result.GetRawResponse());
         }