Prevent crash when computing emit output paths - #4900
Draft
Daniel Rosenwasser (DanielRosenwasser) with Copilot wants to merge 6 commits into
Draft
Prevent crash when computing emit output paths#4900Daniel Rosenwasser (DanielRosenwasser) with Copilot wants to merge 6 commits into
Daniel Rosenwasser (DanielRosenwasser) with Copilot wants to merge 6 commits into
Conversation
Copilot started work on behalf of
Daniel Rosenwasser (DanielRosenwasser)
August 13, 2026 22:11
View session
Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix crash at GetSourceFilePathInNewDir
Prevent crash when computing emit output paths
Aug 13, 2026
Member
|
Copilot this really needs an integration/compiler test as well. |
Copilot started work on behalf of
Daniel Rosenwasser (DanielRosenwasser)
August 14, 2026 17:03
View session
Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetSourceFilePathInNewDircould panic when normalized path containment succeeded but the raw common-directory string was longer than the source path, causing an out-of-bounds slice.Output path handling
GetSourceFilePathInNewDirWorker, matching the TypeScript reference implementation’s canonical prefix behavior.Regression coverage
GetSourceFilePathInNewDir#4899