fix(4863): fix declaration emit for jsdoc functions - #4873
Merged
Conversation
Copilot started reviewing on behalf of
Oleksandr Tarasiuk (a-tarasyuk)
August 11, 2026 08:40
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes declaration emit for JSDoc @type-annotated function declarations referencing external types.
Changes:
- Correctly distinguishes full JSDoc signatures from overload implementations.
- Adds a compiler regression test and declaration/type/symbol baselines.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
internal/checker/emitresolver.go |
Prevents valid JSDoc functions from being elided. |
testdata/tests/cases/compiler/jsDeclarationEmitFunction.ts |
Adds the regression case. |
testdata/baselines/reference/compiler/jsDeclarationEmitFunction.js |
Verifies declaration output. |
testdata/baselines/reference/compiler/jsDeclarationEmitFunction.types |
Records inferred types. |
testdata/baselines/reference/compiler/jsDeclarationEmitFunction.symbols |
Records symbol bindings. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4863