-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix false-positive TS2354 for native private class field access with importHelpers at dated targets #4841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andrew Stegmaier (astegmaier)
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
astegmaier:fix-63728-private-field-tslib-false-positive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix false-positive TS2354 for native private class field access with importHelpers at dated targets #4841
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
testdata/baselines/reference/compiler/importHelpersNoHelpersForPrivateFieldsAtES2022.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| //// [tests/cases/compiler/importHelpersNoHelpersForPrivateFieldsAtES2022.ts] //// | ||
|
|
||
| //// [main.ts] | ||
| export class Foo { | ||
| #field = true; | ||
| static #staticField = true; | ||
| #method() {} | ||
| static #staticMethod() {} | ||
| get #accessor() { return this.#field; } | ||
| set #accessor(v: boolean) { this.#field = v; } | ||
| accessor #autoAccessor = true; | ||
| static accessor #staticAutoAccessor = true; | ||
| static { | ||
| Foo.#staticField = true; | ||
| } | ||
| f() { | ||
| this.#field = this.#field; | ||
| this.#method(); | ||
| Foo.#staticField = Foo.#staticField; | ||
| Foo.#staticMethod(); | ||
| this.#accessor = this.#accessor; | ||
| this.#autoAccessor = this.#autoAccessor; | ||
| Foo.#staticAutoAccessor = Foo.#staticAutoAccessor; | ||
| #field in this; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| //// [main.js] | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| exports.Foo = void 0; | ||
| class Foo { | ||
| #field = true; | ||
| static #staticField = true; | ||
| #method() { } | ||
| static #staticMethod() { } | ||
| get #accessor() { return this.#field; } | ||
| set #accessor(v) { this.#field = v; } | ||
| #autoAccessor_accessor_storage = true; | ||
| get #autoAccessor() { return this.#autoAccessor_accessor_storage; } | ||
| set #autoAccessor(value) { this.#autoAccessor_accessor_storage = value; } | ||
| static #staticAutoAccessor_accessor_storage = true; | ||
| static get #staticAutoAccessor() { return Foo.#staticAutoAccessor_accessor_storage; } | ||
| static set #staticAutoAccessor(value) { Foo.#staticAutoAccessor_accessor_storage = value; } | ||
| static { | ||
| Foo.#staticField = true; | ||
| } | ||
| f() { | ||
| this.#field = this.#field; | ||
| this.#method(); | ||
| Foo.#staticField = Foo.#staticField; | ||
| Foo.#staticMethod(); | ||
| this.#accessor = this.#accessor; | ||
| this.#autoAccessor = this.#autoAccessor; | ||
| Foo.#staticAutoAccessor = Foo.#staticAutoAccessor; | ||
| #field in this; | ||
| } | ||
| } | ||
| exports.Foo = Foo; |
88 changes: 88 additions & 0 deletions
88
testdata/baselines/reference/compiler/importHelpersNoHelpersForPrivateFieldsAtES2022.symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| //// [tests/cases/compiler/importHelpersNoHelpersForPrivateFieldsAtES2022.ts] //// | ||
|
|
||
| === main.ts === | ||
| export class Foo { | ||
| >Foo : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
|
|
||
| #field = true; | ||
| >#field : Symbol(Foo.#field, Decl(main.ts, 0, 18)) | ||
|
|
||
| static #staticField = true; | ||
| >#staticField : Symbol(Foo.#staticField, Decl(main.ts, 1, 18)) | ||
|
|
||
| #method() {} | ||
| >#method : Symbol(Foo.#method, Decl(main.ts, 2, 31)) | ||
|
|
||
| static #staticMethod() {} | ||
| >#staticMethod : Symbol(Foo.#staticMethod, Decl(main.ts, 3, 16)) | ||
|
|
||
| get #accessor() { return this.#field; } | ||
| >#accessor : Symbol(Foo.#accessor, Decl(main.ts, 4, 29), Decl(main.ts, 5, 43)) | ||
| >this.#field : Symbol(Foo.#field, Decl(main.ts, 0, 18)) | ||
| >this : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
|
|
||
| set #accessor(v: boolean) { this.#field = v; } | ||
| >#accessor : Symbol(Foo.#accessor, Decl(main.ts, 4, 29), Decl(main.ts, 5, 43)) | ||
| >v : Symbol(v, Decl(main.ts, 6, 18)) | ||
| >this.#field : Symbol(Foo.#field, Decl(main.ts, 0, 18)) | ||
| >this : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
| >v : Symbol(v, Decl(main.ts, 6, 18)) | ||
|
|
||
| accessor #autoAccessor = true; | ||
| >#autoAccessor : Symbol(Foo.#autoAccessor, Decl(main.ts, 6, 50)) | ||
|
|
||
| static accessor #staticAutoAccessor = true; | ||
| >#staticAutoAccessor : Symbol(Foo.#staticAutoAccessor, Decl(main.ts, 7, 34)) | ||
|
|
||
| static { | ||
| Foo.#staticField = true; | ||
| >Foo.#staticField : Symbol(Foo.#staticField, Decl(main.ts, 1, 18)) | ||
| >Foo : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
| } | ||
| f() { | ||
| >f : Symbol(Foo.f, Decl(main.ts, 11, 5)) | ||
|
|
||
| this.#field = this.#field; | ||
| >this.#field : Symbol(Foo.#field, Decl(main.ts, 0, 18)) | ||
| >this : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
| >this.#field : Symbol(Foo.#field, Decl(main.ts, 0, 18)) | ||
| >this : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
|
|
||
| this.#method(); | ||
| >this.#method : Symbol(Foo.#method, Decl(main.ts, 2, 31)) | ||
| >this : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
|
|
||
| Foo.#staticField = Foo.#staticField; | ||
| >Foo.#staticField : Symbol(Foo.#staticField, Decl(main.ts, 1, 18)) | ||
| >Foo : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
| >Foo.#staticField : Symbol(Foo.#staticField, Decl(main.ts, 1, 18)) | ||
| >Foo : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
|
|
||
| Foo.#staticMethod(); | ||
| >Foo.#staticMethod : Symbol(Foo.#staticMethod, Decl(main.ts, 3, 16)) | ||
| >Foo : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
|
|
||
| this.#accessor = this.#accessor; | ||
| >this.#accessor : Symbol(Foo.#accessor, Decl(main.ts, 4, 29), Decl(main.ts, 5, 43)) | ||
| >this : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
| >this.#accessor : Symbol(Foo.#accessor, Decl(main.ts, 4, 29), Decl(main.ts, 5, 43)) | ||
| >this : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
|
|
||
| this.#autoAccessor = this.#autoAccessor; | ||
| >this.#autoAccessor : Symbol(Foo.#autoAccessor, Decl(main.ts, 6, 50)) | ||
| >this : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
| >this.#autoAccessor : Symbol(Foo.#autoAccessor, Decl(main.ts, 6, 50)) | ||
| >this : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
|
|
||
| Foo.#staticAutoAccessor = Foo.#staticAutoAccessor; | ||
| >Foo.#staticAutoAccessor : Symbol(Foo.#staticAutoAccessor, Decl(main.ts, 7, 34)) | ||
| >Foo : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
| >Foo.#staticAutoAccessor : Symbol(Foo.#staticAutoAccessor, Decl(main.ts, 7, 34)) | ||
| >Foo : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
|
|
||
| #field in this; | ||
| >#field : Symbol(Foo.#field, Decl(main.ts, 0, 18)) | ||
| >this : Symbol(Foo, Decl(main.ts, 0, 0)) | ||
| } | ||
| } | ||
|
|
103 changes: 103 additions & 0 deletions
103
testdata/baselines/reference/compiler/importHelpersNoHelpersForPrivateFieldsAtES2022.types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| //// [tests/cases/compiler/importHelpersNoHelpersForPrivateFieldsAtES2022.ts] //// | ||
|
|
||
| === main.ts === | ||
| export class Foo { | ||
| >Foo : Foo | ||
|
|
||
| #field = true; | ||
| >#field : boolean | ||
| >true : true | ||
|
|
||
| static #staticField = true; | ||
| >#staticField : boolean | ||
| >true : true | ||
|
|
||
| #method() {} | ||
| >#method : () => void | ||
|
|
||
| static #staticMethod() {} | ||
| >#staticMethod : () => void | ||
|
|
||
| get #accessor() { return this.#field; } | ||
| >#accessor : boolean | ||
| >this.#field : boolean | ||
| >this : this | ||
|
|
||
| set #accessor(v: boolean) { this.#field = v; } | ||
| >#accessor : boolean | ||
| >v : boolean | ||
| >this.#field = v : boolean | ||
| >this.#field : boolean | ||
| >this : this | ||
| >v : boolean | ||
|
|
||
| accessor #autoAccessor = true; | ||
| >#autoAccessor : boolean | ||
| >true : true | ||
|
|
||
| static accessor #staticAutoAccessor = true; | ||
| >#staticAutoAccessor : boolean | ||
| >true : true | ||
|
|
||
| static { | ||
| Foo.#staticField = true; | ||
| >Foo.#staticField = true : true | ||
| >Foo.#staticField : boolean | ||
| >Foo : typeof Foo | ||
| >true : true | ||
| } | ||
| f() { | ||
| >f : () => void | ||
|
|
||
| this.#field = this.#field; | ||
| >this.#field = this.#field : boolean | ||
| >this.#field : boolean | ||
| >this : this | ||
| >this.#field : boolean | ||
| >this : this | ||
|
|
||
| this.#method(); | ||
| >this.#method() : void | ||
| >this.#method : () => void | ||
| >this : this | ||
|
|
||
| Foo.#staticField = Foo.#staticField; | ||
| >Foo.#staticField = Foo.#staticField : boolean | ||
| >Foo.#staticField : boolean | ||
| >Foo : typeof Foo | ||
| >Foo.#staticField : boolean | ||
| >Foo : typeof Foo | ||
|
|
||
| Foo.#staticMethod(); | ||
| >Foo.#staticMethod() : void | ||
| >Foo.#staticMethod : () => void | ||
| >Foo : typeof Foo | ||
|
|
||
| this.#accessor = this.#accessor; | ||
| >this.#accessor = this.#accessor : boolean | ||
| >this.#accessor : boolean | ||
| >this : this | ||
| >this.#accessor : boolean | ||
| >this : this | ||
|
|
||
| this.#autoAccessor = this.#autoAccessor; | ||
| >this.#autoAccessor = this.#autoAccessor : boolean | ||
| >this.#autoAccessor : boolean | ||
| >this : this | ||
| >this.#autoAccessor : boolean | ||
| >this : this | ||
|
|
||
| Foo.#staticAutoAccessor = Foo.#staticAutoAccessor; | ||
| >Foo.#staticAutoAccessor = Foo.#staticAutoAccessor : boolean | ||
| >Foo.#staticAutoAccessor : boolean | ||
| >Foo : typeof Foo | ||
| >Foo.#staticAutoAccessor : boolean | ||
| >Foo : typeof Foo | ||
|
|
||
| #field in this; | ||
| >#field in this : boolean | ||
| >#field : any | ||
| >this : this | ||
| } | ||
| } | ||
|
|
36 changes: 36 additions & 0 deletions
36
...ce/compiler/importHelpersNoHelpersForPrivateFieldsAtES2022UseDefineForClassFieldsFalse.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| //// [tests/cases/compiler/importHelpersNoHelpersForPrivateFieldsAtES2022UseDefineForClassFieldsFalse.ts] //// | ||
|
|
||
| //// [main.ts] | ||
| export class Foo { | ||
| #field = true; | ||
| static #staticField = true; | ||
| #method() {} | ||
| static #staticMethod() {} | ||
| f() { | ||
| this.#field = this.#field; | ||
| this.#method(); | ||
| Foo.#staticField = Foo.#staticField; | ||
| Foo.#staticMethod(); | ||
| #field in this; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| //// [main.js] | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| exports.Foo = void 0; | ||
| class Foo { | ||
| #field = true; | ||
| static #staticField = true; | ||
| #method() { } | ||
| static #staticMethod() { } | ||
| f() { | ||
| this.#field = this.#field; | ||
| this.#method(); | ||
| Foo.#staticField = Foo.#staticField; | ||
| Foo.#staticMethod(); | ||
| #field in this; | ||
| } | ||
| } | ||
| exports.Foo = Foo; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This currently doesn't actually check that the member in question is privately named (or produces a private name) - I'd expect a
ast.IsPrivateIdentifierClassElementDeclaration(member) || ast.IsAutoAccessorPropertyDeclaration(member)like you see in the esdecorator transform somewhere.