Skip to content

Preserve nested module resolution diagnostics in concurrent mode - #4836

Open
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 5 commits into
mainfrom
copilot/ts2307-default-concurrent-mode-fix
Open

Preserve nested module resolution diagnostics in concurrent mode#4836
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 5 commits into
mainfrom
copilot/ts2307-default-concurrent-mode-fix

Conversation

Copilot AI commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Concurrent checking omitted TS2307 for import/export declarations inside blocks that do not create declaration scopes, while single-threaded mode reported it.

  • Checker

    • Resolve external module names before returning from illegal-context grammar checks when the declaration binds to the source-file scope.
    • Preserve existing behavior for side-effect imports and declarations inside true scopes.
  • Coverage

    • Add CLI baselines confirming concurrent and single-threaded parity for:
      {
          export { a } from "exportNamed";
          export * from "exportStar";
          import { b } from "importNamed";
          import c = require("importEquals");
          import "sideEffect";
      }
    • Accept the corresponding upstream baseline delta.

Copilot AI and others added 3 commits August 5, 2026 23:55
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix TS2307 missing error in default concurrent mode Preserve nested module resolution diagnostics in concurrent mode Aug 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a baseline test, not a unit test

Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

@jakebailey

Copy link
Copy Markdown
Member

I have no idea why GitHub thinks I'm the last pusher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default concurrent mode misses TS2307 that --singleThreaded (and TS 6.0) report, for import/export declarations inside non-scope blocks

4 participants