API: Add declaration property to IndexInfo.#4273
Open
piotrtomiak wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Exposes the AST declaration for index signatures through the Go API and surfaces it in the native-preview TypeScript clients.
Changes:
- Added
IndexInfo.Declaration()to access the index signature’s declaration node. - Extended
IndexInfoResponseto include an optionaldeclarationnode handle and populated it in the session handler. - Updated native-preview sync/async TS proto + typed APIs to carry and hydrate the new
declarationfield.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/checker/types.go | Adds a getter for the index signature declaration node. |
| internal/api/session.go | Includes the declaration node handle in index-info results when available. |
| internal/api/proto.go | Extends IndexInfoResponse with a declaration field. |
| _packages/native-preview/src/api/proto.ts | Adds declaration?: string to the TS response shape. |
| _packages/native-preview/src/api/sync/types.ts | Adds declaration?: NodeHandle to IndexInfo. |
| _packages/native-preview/src/api/sync/api.ts | Hydrates declaration into a NodeHandle when present. |
| _packages/native-preview/src/api/async/types.ts | Adds declaration?: NodeHandle to IndexInfo. |
| _packages/native-preview/src/api/async/api.ts | Hydrates declaration into a NodeHandle when present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found out one more missing API for WebStorm integration - lack of
declarationproperty on theIndexInfoobject.