Add test for MSTEST0026 right operand conditional access

[Evangelink]

Summary

• cover conditional access in the right operand of binary expressions for MSTEST0026
• verify diagnostics for Assert.IsTrue and Assert.IsFalse
• verify the code fix inserts a null assertion and removes conditional access

Testing

• targeted MSTest.Analyzers.UnitTests test passed on net8.0

Closes #10153

[Copilot]

Pull request overview

Adds targeted MSTEST0026 coverage for conditional access on a binary expression’s right operand.

Changes:

• Tests diagnostics for Assert.IsTrue and Assert.IsFalse.
• Verifies the fix adds one null assertion and removes conditional access.

Show a summary per file

File	Description
AssertionArgsShouldAvoidConditionalAccessAnalyzerTests.cs	Adds right-operand analyzer and code-fix coverage.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Medium

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

This PR adds a well-structured test covering the binaryOperation.RightOperand path in HasAnyConditionalAccessOperationChild. Reviewed across all 22 dimensions — no actionable issues found.

Dimension	Verdict
Correctness	✅ Clean
Test Quality	✅ Clean
Naming & Readability	✅ Clean
Assertion Quality	✅ Clean
Coverage Completeness	✅ Clean
Threading	N/A (test-only)
Security	N/A
Public API	N/A
Performance	N/A
Backward Compat	N/A
Error Handling	N/A
Localization	N/A
Documentation	✅ Clean (comment explains intent)
Code Style	✅ Clean
Duplication	✅ Clean
Dependencies	N/A
Disposal	N/A
Nullability	✅ Clean
Platform Compat	N/A
Diagnostics/Logging	N/A
Serialization	N/A
Extensibility	N/A

Overall: Ship it. The test is correct, well-named, exercises two distinct binary patterns (< and ==), validates both the diagnostic and the code fix, and uses appropriate iteration counts.

[github-actions]

🧪 Test quality grade — PR #10178

Grade	Test	Notes
B (80–89)	new AssertionArgsShouldAvoidConditionalAccessAnalyzerTests. WhenConditionalAccessIsRightOperandOfBinaryExpression_ Diagnostic	Solid diagnostic + fix verification via [|...|] markers and FixedCode; body is ~46 lines (inherent to Roslyn string-embedded tests) — consider extracting shared code strings into helpers if this pattern recurs.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · sonnet46 29.8 AIC · ⌖ 5.68 AIC · ⊞ 9K · [◷]( · ◷)