Skip to content

[v5] Remove TestRequestExecutionTimeInfo compatibility shim#10177

Merged
Evangelink merged 3 commits into
rel/v5.0from
dev/amauryleve/remove-execution-time-shim
Jul 23, 2026
Merged

[v5] Remove TestRequestExecutionTimeInfo compatibility shim#10177
Evangelink merged 3 commits into
rel/v5.0from
dev/amauryleve/remove-execution-time-shim

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • remove the obsolete TestRequestExecutionTimeInfo compatibility type and its publisher
  • stop TestHostTestFrameworkInvoker from implementing IDataProducer
  • update internal API tracking and pin forward-compat coverage to Microsoft.Testing.Platform.MSBuild 2.3.0

Testing

  • built Microsoft.Testing.Platform
  • passed ForwardCompatibilityTests.NewerPlatform_WithPreviousExtensions_ShouldExecuteTests

Fixes #8925

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c92b504d-fa69-4848-9aa7-5e9c694ed934
@Evangelink
Evangelink enabled auto-merge (squash) July 23, 2026 14:25
@Evangelink Evangelink added the state/needs-review Awaiting review from the team. label Jul 23, 2026
@Evangelink Evangelink changed the title Remove TestRequestExecutionTimeInfo compatibility shim [v5] Remove TestRequestExecutionTimeInfo compatibility shim Jul 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10177

GradeTestNotes
F (0–59) new DummyClass.
DummyTestMethod
Empty body by design — explicitly a discovery fixture; consider [Ignore] so it does not count as a real test run in CI.
F (0–59) new MSTestDiscovererTests.
DiscoverTestsShouldNotThrowIfDiscoveryContextIsNull
No explicit assertion — the implicit "does not throw" intent should be expressed as action.Should().NotThrow() for clarity and to guard against future swallowed exceptions.
B (80–89) mod DotnetTestProtocolContractTests.
HandshakeMessagePropertyNames_
AreStable
Strong pin-test with 16 equality assertions; ~40-line body is inherent to the design but slightly exceeds the structural A-threshold — no actionable improvement needed.
B (80–89) mod ProtocolTests.
HandshakeMessagePropertyNames_
ValuesAreStable
Same as above — thorough protocol-stability pin with ~45-line body; body length is structural, not a quality concern.
A (90–100) mod DotnetTestProtocolContractTests.
ProtocolVersion_
IsStable
No issues found.
A (90–100) new MSTestDiscovererTests.
AdapterSettingsExceptionShouldSetInnerExceptionWhenProvided
No issues found.
A (90–100) new MSTestDiscovererTests.
AreValidSourcesShouldReturnFalseForInvalidSourceExtensions
No issues found.
A (90–100) new MSTestDiscovererTests.
AreValidSourcesShouldReturnFalseIfValidSourceExtensionsIsEmpty
No issues found.
A (90–100) new MSTestDiscovererTests.
AreValidSourcesShouldReturnTrueForValidSourceExtensions
No issues found.
A (90–100) new MSTestDiscovererTests.
AreValidSourcesShouldThrowIfPlatformsValidSourceExtensionsIsNull
No issues found.
A (90–100) new MSTestDiscovererTests.
DiscoverTestsShouldDiscoverTests
No issues found.
A (90–100) new MSTestDiscovererTests.
DiscoverTestsShouldThrowIfDiscoverySinkIsNull
No issues found.
A (90–100) new MSTestDiscovererTests.
DiscoverTestsShouldThrowIfLoggerIsNull
No issues found.
A (90–100) new MSTestDiscovererTests.
DiscoverTestsShouldThrowIfSourcesAreNotValid
No issues found.
A (90–100) new MSTestDiscovererTests.
DiscoverTestsShouldThrowIfSourcesIsNull
No issues found.
A (90–100) new MSTestDiscovererTests.
DiscoveryShouldReportAndBailOutOnSettingsException
No issues found.
A (90–100) new MSTestDiscovererTests.
GetSettingsExceptionMessageShouldIncludeMalformedXmlDetailsFromPopulateSettings
No issues found.
A (90–100) new MSTestDiscovererTests.
GetSettingsExceptionMessageShouldReturnPlainMessageWhenThereIsNoInnerException
No issues found.
A (90–100) new MSTestDiscovererTests.
MSTestDiscovererHasAppxAsFileExtension
No issues found.
A (90–100) new MSTestDiscovererTests.
MSTestDiscovererHasDllAsFileExtension
No issues found.
A (90–100) new MSTestDiscovererTests.
MSTestDiscovererHasExeAsFileExtension
Nearly clean; object value = attributes.Should().NotBeNull() assigns an unused variable — consider removing the assignment.
A (90–100) new MSTestDiscovererTests.
MSTestDiscovererHasMSTestAdapterAsExecutorUri
No issues found.
A (90–100) new MSTestDiscovererTests.
MSTestDiscovererHasXapAsFileExtension
No issues found.
A (90–100) new MSTestExecutorTests.
MSTestExecutorShouldProvideTestExecutionUri
No issues found.
A (90–100) new MSTestExecutorTests.
RunTestsShouldReportErrorAndBailOutOnSettingsException
No issues found.
A (90–100) new MSTestExecutorTests.
RunTestsWithSourcesShouldReportErrorAndBailOutOnSettingsException
No issues found.
A (90–100) mod PlatformCommandLineProviderTests.
IsInvalid_
When_
Server_
DotnetTestCli_
Without_
DotnetTestPipe
No issues found.
A (90–100) mod ProtocolTests.
ProtocolVersion_
IsStable
No issues found.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · sonnet46 138.5 AIC · ⌖ 11.5 AIC · ⊞ 9K · [◷]( · )

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c92b504d-fa69-4848-9aa7-5e9c694ed934
@Evangelink
Evangelink merged commit 0c5a71b into rel/v5.0 Jul 23, 2026
28 of 29 checks passed
@Evangelink
Evangelink deleted the dev/amauryleve/remove-execution-time-shim branch July 23, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants