Skip to content

.Net: Remove migrated .NET Milvus connector - #14682

Merged
Adam Sitnik (adamsitnik) merged 1 commit into
mainfrom
copilot/remove-migrated-milvus-connector
Oct 30, 2026
Merged

Adam Sitnik (adamsitnik) merged 1 commit into
mainfrom
copilot/remove-migrated-milvus-connector

Conversation

@adamsitnik

Copy link
Copy Markdown
Member

Motivation and Context

Follow the Chroma cleanup in #14579 now that the Milvus provider has merged in CommunityToolkit/AI#77 and is published as CommunityToolkit.VectorData.Milvus.

Description

  • Remove the legacy .NET Milvus memory store and its tests.
  • Replace its README with a deprecation notice linking to the Toolkit package and implementation.
  • Remove unused Milvus package references and the experimental-feature entry.
  • Delete MEVD.slnx, which has no projects left after this removal.

Validation:

  • git diff --check — passed.
  • dotnet msbuild dotnet/src/IntegrationTests/IntegrationTests.csproj -getItem:PackageReference -verbosity:quiet — passed; evaluated package references contain no Milvus dependency.
  • dotnet msbuild dotnet/src/Experimental/Process.IntegrationTestRunner.Dapr/Process.IntegrationTestRunner.Dapr.csproj -getItem:PackageReference -verbosity:quiet — passed; evaluated package references contain no Milvus dependency.
  • Full builds, unit tests, and dotnet format were not run. The Milvus implementation and test project are removed; the remaining changes are documentation, solution, and dependency cleanup.

Contribution Checklist

Remove the legacy Milvus memory store and tests now that the VectorData provider is available in CommunityToolkit/AI. Point users to the published package and remove unused dependencies and the empty MEVD solution.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@semantic-kernel-automation semantic-kernel-automation Bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel documentation labels Oct 29, 2026
@adamsitnik
Adam Sitnik (adamsitnik) marked this pull request as ready for review October 30, 2026 08:24
@adamsitnik
Adam Sitnik (adamsitnik) requested a review from a team as a code owner October 30, 2026 08:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the legacy Milvus connector removal.

No open issues 🎉

What changed in this PR

Removes the legacy .NET Milvus connector following its migration to CommunityToolkit/AI, continuing the cleanup started with the Chroma connector in #14579.

Changes:

  • Deletes the Milvus memory-store implementation, test project, and associated tests.
  • Replaces the README with a deprecation notice linking to the CommunityToolkit package and implementation.
  • Removes unused dependencies, the experimental-feature entry, and the now-empty MEVD.slnx.
File Description
dotnet/​test/​VectorData/​Milvus.UnitTests/​MilvusMemoryStoreTests.cs Removes memory-store integration tests.
dotnet/​test/​VectorData/​Milvus.UnitTests/​MilvusLegacyServerTests.cs Removes legacy-server compatibility tests.
dotnet/​test/​VectorData/​Milvus.UnitTests/​MilvusFixture.cs Removes the Milvus container fixture.
dotnet/​test/​VectorData/​Milvus.UnitTests/​MilvusFilterTests.cs Removes ID-filter and server-version tests.
dotnet/​test/​VectorData/​Milvus.UnitTests/​Milvus.UnitTests.csproj Deletes the Milvus test project.
dotnet/​src/​VectorData/​Milvus/​README.md Directs users to the CommunityToolkit replacement.
dotnet/​src/​VectorData/​Milvus/​MilvusMemoryStore.cs Deletes the legacy memory-store implementation.
dotnet/​src/​VectorData/​Milvus/​Milvus.csproj Deletes the connector project.
dotnet/​src/​VectorData/​Milvus/​AssemblyInfo.cs Removes the connector’s experimental annotation.
dotnet/​src/​IntegrationTests/​IntegrationTests.csproj Removes the unused Milvus test-container dependency.
dotnet/​src/​Experimental/​Process.IntegrationTestRunner.Dapr/​Process.IntegrationTestRunner.Dapr.csproj Removes the unused Milvus test-container dependency.
dotnet/​MEVD.slnx Deletes the solution after removing its remaining projects.
dotnet/​docs/​EXPERIMENTS.md Removes the Milvus experimental-feature listing.
dotnet/​Directory.Packages.props Removes central Milvus package versions.

Review effort: Balanced

@adamsitnik
Adam Sitnik (adamsitnik) added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit a77c8ac Oct 30, 2026
23 checks passed
@adamsitnik
Adam Sitnik (adamsitnik) deleted the copilot/remove-migrated-milvus-connector branch October 30, 2026 11:10

This branch was successfully deployed

2 active deployments
integration — 630d155b Deployed Oct 29, 2026 by adamsitnik via dotnet-integration-tests #32982
github-app-auth — 630d155b Deployed Oct 29, 2026 by adamsitnik via add_label #29492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants