.Net: preserve root $defs/definitions when wrapping AIFunction tools#13568
Open
OiPunk wants to merge 1 commit intomicrosoft:mainfrom
Open
.Net: preserve root $defs/definitions when wrapping AIFunction tools#13568OiPunk wants to merge 1 commit intomicrosoft:mainfrom
OiPunk wants to merge 1 commit intomicrosoft:mainfrom
Conversation
moonbox3
added
.NET
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves root-level JSON schema definitions (
$defs/definitions) when wrappingAIFunctiontools asKernelFunction.Fixes #13447.
Problem
AIFunctionKernelFunctioncurrently builds schema metadata from parameter properties. During that conversion, root-level schema sections like$defs/definitionsare dropped.When a property schema still contains
$ref(for example#/$defs/Node), this produces an incomplete tool schema for model calls.Changes
AIFunctionKernelFunctionnow stores and returns the originalaiFunction.JsonSchema.$defsare preserved.Validation
GITHUB_ACTIONS=1 dotnet test dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj --configuration Release --filter FullyQualifiedName~AIFunctionKernelFunctionTestsGITHUB_ACTIONS=1 dotnet test dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj --configuration Release --no-build --filter FullyQualifiedName~AIFunctionKernelFunctionTests --collect:"XPlat Code Coverage"AIFunctionKernelFunctionline-rate:1.0(100%)