Skip to content

Python: Fix GoogleAI validation: skip API key check when using Vertex AI #13518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veeceey wants to merge 3 commits into from
Closed

Python: Fix GoogleAI validation: skip API key check when using Vertex AI #13518

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1eccdc
fix: skip API key validation when using Vertex AI authentication
veeceey Feb 7, 2026
6535084
Fix too-long line in Vertex AI test to pass pre-commit check
veeceey Feb 10, 2026
8176b81
retrigger CI
veeceey Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions python/tests/unit/connectors/ai/google/google_ai/services/test_google_ai_chat_completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,21 @@ def test_google_ai_chat_completion_init_with_use_vertexai_missing_region(google_


@pytest.mark.parametrize("exclude_list", [["GOOGLE_AI_API_KEY"]], indirect=True)
def test_google_ai_chat_completion_init_with_use_vertexai_no_api_key(google_ai_unit_test_env) -> None:
"""Test initialization of GoogleAIChatCompletion succeeds with use_vertexai=True and no api_key"""
chat_completion = GoogleAIChatCompletion(use_vertexai=True)
assert chat_completion.service_settings.use_vertexai is True
def test_google_ai_chat_completion_init_with_vertexai_without_api_key(google_ai_unit_test_env) -> None:
"""Test initialization of GoogleAIChatCompletion with use_vertexai true and no API key"""
# This should succeed because API key is not required when using Vertex AI
google_ai_chat_completion = GoogleAIChatCompletion(
use_vertexai=True,
project_id=google_ai_unit_test_env["GOOGLE_AI_CLOUD_PROJECT_ID"],
env_file_path="fake_env_file_path.env",
)

assert google_ai_chat_completion.ai_model_id == google_ai_unit_test_env["GOOGLE_AI_GEMINI_MODEL_ID"]
assert google_ai_chat_completion.service_settings.use_vertexai is True
assert (
google_ai_chat_completion.service_settings.cloud_project_id
== google_ai_unit_test_env["GOOGLE_AI_CLOUD_PROJECT_ID"]
)


def test_prompt_execution_settings_class(google_ai_unit_test_env) -> None:
Expand Down
Loading