Skip to content

Revert "[0.81]Fix crash in ABIViewManager::RemoveAllChildren during shutdown" #15695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HariniMalothu17 wants to merge 1 commit into
base: 0.81-stable
Choose a base branch
from
+1 −12
Open

Revert "[0.81]Fix crash in ABIViewManager::RemoveAllChildren during shutdown" #15695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions vnext/Microsoft.ReactNative/ABIViewManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,19 +190,8 @@ void ABIViewManager::AddView(const xaml::DependencyObject &parent, const xaml::D
}

void ABIViewManager::RemoveAllChildren(const xaml::DependencyObject &parent) {
if (!parent) {
return;
}

if (m_viewManagerWithChildren) {
auto fe = parent.try_as<xaml::FrameworkElement>();
if (fe) {
try {
m_viewManagerWithChildren.RemoveAllChildren(fe);
} catch (...) {
// External view manager may fail during shutdown if view is already disposed
}
}
m_viewManagerWithChildren.RemoveAllChildren(parent.as<xaml::FrameworkElement>());
} else {
Super::RemoveAllChildren(parent);
}
Expand Down
Loading