Skip to content

refactor: use built-in Error.isError #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tido64 wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

refactor: use built-in Error.isError #2892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/scripts/testing/test-matrix.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ if (platforms.length === 0) {
process.exitCode = e;
} else {
process.exitCode = 1;
showBanner(`❌ ${(e instanceof Error && e.stack) || e}`);
showBanner(`❌ ${(Error.isError(e) && e.stack) || e}`);
}
});
}
4 changes: 2 additions & 2 deletions packages/app/test/windows/copyAndReplace.test.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ describe("copyAndReplace()", () => {

it("throws on error", async () => {
await rejects(copyAndReplace("ReactTestApp.png", "", {}), (err) => {
if (!(err instanceof Error)) {
if (!Error.isError(err)) {
fail("Expected an Error");
}
match(err.message, /ENOENT/);
return true;
});
await rejects(copyAndReplace("ReactTestApp.sln", "", {}), (err) => {
if (!(err instanceof Error)) {
if (!Error.isError(err)) {
fail("Expected an Error");
}
match(err.message, /ENOENT/);
Expand Down
2 changes: 1 addition & 1 deletion packages/app/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"target": "esnext",
"allowImportingTsExtensions": true,
"noEmit": true,
"lib": ["ES2022", "DOM"]
"lib": ["esnext", "dom"]
},
"include": [
"**/*.mjs",
Expand Down
Loading