Fix calculated compute properties for callables invoked from parallel exprs - #3592
Open
Stefan J. Wernli (swernli) wants to merge 2 commits into
Open
Fix calculated compute properties for callables invoked from parallel exprs#3592Stefan J. Wernli (swernli) wants to merge 2 commits into
parallel exprs#3592Stefan J. Wernli (swernli) wants to merge 2 commits into
Conversation
…l` exprs This fixes a bug in how compute proerties were calculated by RCA and queried during Partial Eval when the callable being invoked is inside of a parallel expression. Since parallel expressions force inlining and unrolling, the invoked callable uses different capabilities than what would be computed by default. This avoids computing every callable twice by only inserting into a parallel data structure those specializations that are invoked from within a parallel expr. As a result, code that doesn't use parallel keeps the same behavior, but code that does parallel will compute extra, parallel-specific properties for those callables used within.
Stefan J. Wernli (swernli)
requested review from
Andrew Casey (amcasey) and
Ian Davis (idavis)
as code owners
August 13, 2026 23:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in how compute proerties were calculated by RCA and queried during Partial Eval when the callable being invoked is inside of a parallel expression. Since parallel expressions force inlining and unrolling, the invoked callable uses different capabilities than what would be computed by default. This avoids computing every callable twice by only inserting into a parallel data structure those specializations that are invoked from within a parallel expr. As a result, code that doesn't use parallel keeps the same behavior, but code that does parallel will compute extra, parallel-specific properties for those callables used within.