add dark theme override for ch-added class#6829
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dark-theme-specific CSS override to improve text contrast for character-level “added” highlights in the diff view (mirroring an existing high-contrast fix referenced in the PR description).
Changes:
- Add a dark theme override targeting
.ch-addedwithin added diff rows intable.diffview.update.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…to srietkerk/dark-tutorial-highlight
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…m/microsoft/pxt-microbit into srietkerk/dark-tutorial-highlight
jwunderl
approved these changes
May 14, 2026
riknoll
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing the fix for microsoft/pxt#11306, I noticed that the same contrast problem was present in the dark theme. This is the same override for high contrast but for the dark theme as well.
I ran Accessibility Insights for all cases and they all pass contrast ratios.