Skip to content

test(firefox): cover COOP navigation with history state - #42788

Open
Devin Rousso (dcrousso) wants to merge 1 commit into
microsoft:mainfrom
dcrousso:fix-42731
Open

Devin Rousso (dcrousso) wants to merge 1 commit into
microsoft:mainfrom
dcrousso:fix-42731

Conversation

@dcrousso

Copy link
Copy Markdown
Contributor

cover initial navigation and evaluation when a page updates history.state under COOP

exercise both COOP alone and COOP with COEP

fix #42731

cover initial navigation and evaluation when a page updates `history.state` under COOP

exercise both COOP alone and COOP with COEP
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:230 › should pretty-print response bodies and show formatting errors @windows-latest-node22

7 flaky ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:521 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`

52033 passed, 1250 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The one failure is a pre-existing UI-mode fixture flake — this PR is clear

Hi, I'm the Playwright bot and I took a look at the failing CI run.

The single failure, [playwright-test] › ui-mode-test-network-tab.spec.ts:230, died in the UI-mode fixture with toHaveTitle can be only used with Page object, was called with undefined — the page handed to the test was never created. The same error hits four other UI-mode tests on the same Windows bot on main-branch SHAs, so it's a harness flake, not your change.

Details

This PR adds two test cases to tests/page/page-goto.spec.ts and changes nothing else — 21 added lines, one file, no product code. The playwright-test project doesn't run tests/page/, so the diff can't reach the failing test at all.

Pre-existing flake / infra

  • [playwright-test] › ui-mode-test-network-tab.spec.ts:230 › should pretty-print response bodies and show formatting errors @windows-latest-node22 — that exact test is green in 4472 of 4473 runs in the aggregated results DB; the single red is this PR's run. On its own that's just a one-off, but the error signature is the giveaway: toHaveTitle can be only used with Page object, was called with undefined shows up once each on four other UI-mode tests, all on windows-latest-node22, all on SHAs unrelated to this PR (pr_number = 0, i.e. main builds):

    • ui-mode-test-network-tab.spec.ts › should filter network requests by multiple resource typesbee00ad
    • ui-mode-test-network-tab.spec.ts › should filter network requests by urlf0e0b59
    • ui-mode-test-watch.spec.ts › should watch all5a52607
    • ui-mode-test-attachments.spec.ts › should contain binary attachment496d93f

    So the UI-mode page fixture intermittently fails to produce a page on this Windows bot, and it lands on whichever test happens to be running. Worth a look on its own, but nothing to do with this PR.

Flaky (passed on retry)

The seven flaky results are all in chromium-library, firefox-library and firefox-page — video screencast, service-worker network events, partitioned cookies. None of them touch page-goto.spec.ts.

One of them is adjacent enough to call out: [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set. It's COOP-related, like your new tests, but it's in a different file that this PR doesn't modify, and it passed on retry.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chromium] › mcp/cli-webmcp.spec.ts:188 › webmcp-call disambiguates same-name tools in identical same-origin frames @mcp-ubuntu-latest-chromium
❌ [firefox] › mcp/cli-devtools.spec.ts:117 › per-part commands extract individual parts @mcp-windows-latest-firefox

8690 passed, 1474 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Both failures are pre-existing flakes — the PR is clear

Hi, I'm the Playwright bot and I triaged the CI failures here.

This PR only adds two tests to tests/page/page-goto.spec.ts; it touches no product code and no MCP code. Both reported failures are in tests/mcp/ CLI specs, and both have a flake record on SHAs this PR can't be responsible for.

Details

Pre-existing flake / infra

Neither spec exercises navigation, COOP/COEP, or history.state, and the diff adds no shared helper, so there's no path from this change to either failure.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Firefox page.goto never resolves on the first navigation to a page with COOP same-origin

1 participant