fix(reporter): surface reporter errors and fail the run#41307
Open
dgozman wants to merge 1 commit into
Open
Conversation
Errors thrown by reporters were swallowed and only printed to the console. They are now re-dispatched through onError() so the other reporters report them, tracked via hasReporterErrors(), and fail the test run as well as the merge-reports command. References microsoft#40983
Contributor
Test results for "MCP"1 failed 7340 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"6 flaky39579 passed, 743 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multiplexerand re-dispatch them throughonError()so they are reported by the other reporters (instead of being swallowed to the console).hasReporterErrors()and fail the test run when one occurs (checked inTestRun.result()and afteronEnd/onExitinfinishTaskRun).merge-reportsfail (exit 1) when a reporter errors; merged test failures still exit 0 as before.References #40983