Skip to content

chore(bidi): add support for emulation.setNetworkConditions#39456

Open
hbenl wants to merge 1 commit intomicrosoft:mainfrom
hbenl:setNetworkConditions
Open

chore(bidi): add support for emulation.setNetworkConditions#39456
hbenl wants to merge 1 commit intomicrosoft:mainfrom
hbenl:setNetworkConditions

Conversation

@hbenl
Copy link
Collaborator

@hbenl hbenl commented Feb 27, 2026

Fixes the following tests:

  • library/popup.spec.ts:
    • "should inherit offline from browser context"
  • library/browsercontext-basic.spec.ts:
    • "should work with offline option"
    • "should emulate offline event"
    • "should emulate navigator.onLine"

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@hbenl hbenl force-pushed the setNetworkConditions branch from 7c53c18 to 445b066 Compare February 27, 2026 15:12
@hbenl hbenl force-pushed the setNetworkConditions branch from 445b066 to 4851943 Compare February 27, 2026 15:39
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [webkit-library] › library/download.spec.ts:399 › download event › should save downloads to artifactsDir @webkit-ubuntu-22.04-node20
❌ [playwright-test] › reporter-line.spec.ts:193 › merged › should show error context with relative path @macos-latest-node20

9 flaky ⚠️ [chromium-library] › library/browser.spec.ts:24 › should create new page @smoke `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/browser.spec.ts:24 › should create new page @smoke `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/browser.spec.ts:24 › should create new page @smoke `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/browser.spec.ts:24 › should create new page @smoke `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/browser.spec.ts:24 › should create new page @smoke `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browser.spec.ts:24 › should create new page @smoke `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browser.spec.ts:24 › should create new page @smoke `@webkit-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:759 › run-server › should upload a folder `@webkit-ubuntu-22.04-node20`

38630 passed, 843 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

12 failed
❌ [chrome] › mcp/init-page.spec.ts:21 › --init-page @mcp-windows-latest
❌ [chrome] › mcp/init-page.spec.ts:39 › --init-page w/ --init-script @mcp-windows-latest
❌ [chromium] › mcp/init-page.spec.ts:21 › --init-page @mcp-windows-latest
❌ [chromium] › mcp/init-page.spec.ts:39 › --init-page w/ --init-script @mcp-windows-latest
❌ [chromium] › mcp/tracing.spec.ts:21 › check that trace is saved with --save-trace @mcp-windows-latest
❌ [firefox] › mcp/init-page.spec.ts:21 › --init-page @mcp-windows-latest
❌ [firefox] › mcp/init-page.spec.ts:39 › --init-page w/ --init-script @mcp-windows-latest
❌ [webkit] › mcp/init-page.spec.ts:21 › --init-page @mcp-windows-latest
❌ [webkit] › mcp/init-page.spec.ts:39 › --init-page w/ --init-script @mcp-windows-latest
❌ [msedge] › mcp/init-page.spec.ts:21 › --init-page @mcp-windows-latest
❌ [msedge] › mcp/init-page.spec.ts:39 › --init-page w/ --init-script @mcp-windows-latest
❌ [webkit] › mcp/http.spec.ts:199 › http transport browser lifecycle (persistent) @mcp-macos-15

5121 passed, 171 skipped


Merge workflow run.

@yury-s
Copy link
Member

yury-s commented Feb 27, 2026

Let's resolve the merge conflict and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants