You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This test throws dialog.dismiss: Test ended. with Firefox/Bidi on Linux (and the failure gets misattributed to another test in CI).
Unlike #39331, this PR only swallows the exception for Firefox/Bidi, so that any unexpected exceptions for other browsers/protocols will still cause the test to fail.
6 failed
❌ [playwright-test] › aria-snapshot-file.spec.ts:180 › should respect timeout @macos-latest-node20
❌ [playwright-test] › playwright.unhandled.spec.ts:67 › should produce unhandledRejection when context.route raises @macos-latest-node20
❌ [playwright-test] › test-step.spec.ts:1053 › web assertion inside expect.poll @macos-latest-node20
❌ [playwright-test] › test-step.spec.ts:1106 › should report expect steps @macos-latest-node20
❌ [playwright-test] › to-have-screenshot.spec.ts:301 › should successfully screenshot a page with infinite animation with disableAnimation: true @macos-latest-node20
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:371 › should not preserve selection across test runs @macos-latest-node20
3 flaky⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@ubuntu-22.04-chromium-tip-of-tree` ⚠️ [webkit-library] › library/browsercontext-add-cookies.spec.ts:426 › should allow unnamed cookies `@webkit-ubuntu-22.04-node20` ⚠️ [playwright-test] › ui-mode-trace.spec.ts:700 › should indicate current test status `@macos-latest-node20`
The reason will be displayed to describe this comment to others. Learn more.
I don't see how this helps, the users don't expect dialog.dismiss() to throw in regular scenarios. Let's just keep the test marked in the bidi expectations as failing for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test throws
dialog.dismiss: Test ended.with Firefox/Bidi on Linux (and the failure gets misattributed to another test in CI).Unlike #39331, this PR only swallows the exception for Firefox/Bidi, so that any unexpected exceptions for other browsers/protocols will still cause the test to fail.