fix(handlers): do not evaluate handler annotations in inspect.signature on Python 3.14 - #3204
Open
Ashraf Ali (ashrafiucse) wants to merge 1 commit into
Open
Ashraf Ali (ashrafiucse) wants to merge 1 commit into
Ashraf Ali (ashrafiucse) wants to merge 1 commit into
Conversation
…re on Python 3.14 Since PEP 649 (Python 3.14), annotations are lazily evaluated and inspect.signature() resolves them eagerly by default. Event listeners and locator handlers annotated with names that only exist under `if TYPE_CHECKING:` therefore raised NameError when the signature was inspected, even though only the parameter list is needed. Ask for unresolved forward references instead. Fixes: microsoft/playwright#42857
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inspect.signature()evaluates the lazily-computed annotations (PEP 649/749) by default, so event listeners and locator handlers annotated with names that only exist underif TYPE_CHECKING:raisedNameErrorwhen Playwright inspected the handler signature — even though only the parameter list is used.signature()compat helper that passesannotation_format=Format.FORWARDREFon Python 3.14+ and is a plaininspect.signature()on older versions, and use it at the two call sites (wrap_handler,LocatorHandler.__call__).Fixes microsoft/playwright#42857