Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
.registerTypeAdapter(Date.class, new DateSerializer())
.registerTypeAdapter(LocalDateTime.class, new LocalDateTimeSerializer())
.registerTypeAdapter(SameSiteAttribute.class, new SameSiteAdapter().nullSafe())
.registerTypeAdapter(AnnotatePosition.class, new ToLowerCaseAndDashSerializer<AnnotatePosition>())
.registerTypeAdapter(BrowserChannel.class, new ToLowerCaseAndDashSerializer<BrowserChannel>())
.registerTypeAdapter(ColorScheme.class, new ToLowerCaseAndDashSerializer<ColorScheme>())
.registerTypeAdapter(Contrast.class, new ToLowerCaseAndDashSerializer<Contrast>())
Expand Down Expand Up @@ -83,7 +84,7 @@
.serializeNulls().create();

static SerializedError serializeError(Throwable e) {
SerializedError result = new SerializedError();

Check failure on line 87 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, chromium)

cannot find symbol

Check failure on line 87 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-15-xlarge, webkit)

cannot find symbol

Check failure on line 87 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (ubuntu-latest, chrome)

cannot find symbol

Check failure on line 87 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, chromium)

cannot find symbol

Check failure on line 87 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, webkit)

cannot find symbol

Check failure on line 87 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, msedge)

cannot find symbol

Check failure on line 87 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, chrome)

cannot find symbol

Check failure on line 87 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, firefox)

cannot find symbol

Check failure on line 87 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, firefox)

cannot find symbol
result.error = new SerializedError.Error();
result.error.message = e.getMessage();
result.error.name = e.getClass().getName();
Expand Down Expand Up @@ -117,13 +118,13 @@
private int lastId = 0;
private final List<JSHandleImpl> handles = new ArrayList<>();
private final SerializedValue serializedValue;

Check failure on line 121 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, chromium)

cannot find symbol

Check failure on line 121 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-15-xlarge, webkit)

cannot find symbol

Check failure on line 121 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (ubuntu-latest, chrome)

cannot find symbol

Check failure on line 121 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, chromium)

cannot find symbol

Check failure on line 121 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, webkit)

cannot find symbol

Check failure on line 121 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, msedge)

cannot find symbol

Check failure on line 121 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, chrome)

cannot find symbol

Check failure on line 121 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, firefox)

cannot find symbol

Check failure on line 121 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, firefox)

cannot find symbol
ValueSerializer(Object value) {
serializedValue = serializeValue(value);
}

SerializedArgument toSerializedArgument() {
SerializedArgument result = new SerializedArgument();

Check failure on line 127 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, chromium)

cannot find symbol

Check failure on line 127 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-15-xlarge, webkit)

cannot find symbol

Check failure on line 127 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (ubuntu-latest, chrome)

cannot find symbol

Check failure on line 127 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, chromium)

cannot find symbol

Check failure on line 127 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, webkit)

cannot find symbol

Check failure on line 127 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, msedge)

cannot find symbol

Check failure on line 127 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, chrome)

cannot find symbol

Check failure on line 127 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, firefox)

cannot find symbol

Check failure on line 127 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, firefox)

cannot find symbol
result.value = serializedValue;
result.handles = new Channel[handles.size()];
int i = 0;
Expand All @@ -136,7 +137,7 @@
}

private SerializedValue serializeValue(Object value) {
SerializedValue result = new SerializedValue();

Check failure on line 140 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, chromium)

cannot find symbol

Check failure on line 140 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-15-xlarge, webkit)

cannot find symbol

Check failure on line 140 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (ubuntu-latest, chrome)

cannot find symbol

Check failure on line 140 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, chromium)

cannot find symbol

Check failure on line 140 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, webkit)

cannot find symbol

Check failure on line 140 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, msedge)

cannot find symbol

Check failure on line 140 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, chrome)

cannot find symbol

Check failure on line 140 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, firefox)

cannot find symbol

Check failure on line 140 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, firefox)

cannot find symbol
if (value instanceof JSHandleImpl) {
result.h = handles.size();
handles.add((JSHandleImpl) value);
Expand Down Expand Up @@ -224,16 +225,16 @@
}

static SerializedArgument serializeArgument(Object arg) {
return new ValueSerializer(arg).toSerializedArgument();

Check failure on line 228 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, chromium)

cannot find symbol

Check failure on line 228 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-15-xlarge, webkit)

cannot find symbol

Check failure on line 228 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (ubuntu-latest, chrome)

cannot find symbol

Check failure on line 228 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, chromium)

cannot find symbol

Check failure on line 228 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, webkit)

cannot find symbol

Check failure on line 228 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, msedge)

cannot find symbol

Check failure on line 228 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, chrome)

cannot find symbol

Check failure on line 228 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, firefox)

cannot find symbol

Check failure on line 228 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, firefox)

cannot find symbol
}

static <T> T deserialize(SerializedValue value) {
return deserialize(value, new HashMap<>());

Check failure on line 232 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, chromium)

cannot find symbol

Check failure on line 232 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-15-xlarge, webkit)

cannot find symbol

Check failure on line 232 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (ubuntu-latest, chrome)

cannot find symbol

Check failure on line 232 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, chromium)

cannot find symbol

Check failure on line 232 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, webkit)

cannot find symbol

Check failure on line 232 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, msedge)

cannot find symbol

Check failure on line 232 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, chrome)

cannot find symbol

Check failure on line 232 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, firefox)

cannot find symbol

Check failure on line 232 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, firefox)

cannot find symbol
}

@SuppressWarnings("unchecked")
private static <T> T deserialize(SerializedValue value, Map<Integer, Object> idToValue) {
if (value.ref != null) {

Check failure on line 237 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, chromium)

cannot find symbol

Check failure on line 237 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-15-xlarge, webkit)

cannot find symbol

Check failure on line 237 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (ubuntu-latest, chrome)

cannot find symbol

Check failure on line 237 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, chromium)

cannot find symbol

Check failure on line 237 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, webkit)

cannot find symbol

Check failure on line 237 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, msedge)

cannot find symbol

Check failure on line 237 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / stable (macos-latest, chrome)

cannot find symbol

Check failure on line 237 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (ubuntu-latest, firefox)

cannot find symbol

Check failure on line 237 in playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

View workflow job for this annotation

GitHub Actions / dev (macos-latest, firefox)

cannot find symbol
return (T) idToValue.get(value.ref);
}
if (value.n != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package com.microsoft.playwright;

import com.microsoft.playwright.options.AnnotatePosition;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

Expand Down Expand Up @@ -247,4 +248,21 @@ void screencastShowAndHideActions() throws Exception {
context.close();
}
}

@Test
void screencastShowActionsShouldAcceptEveryPosition() throws Exception {
BrowserContext context = browser.newContext();
Page page = context.newPage();
try {
page.navigate(server.EMPTY_PAGE);
for (AnnotatePosition position : AnnotatePosition.values()) {
AutoCloseable disposable = page.screencast().showActions(
new Screencast.ShowActionsOptions().setPosition(position));
assertNotNull(disposable);
disposable.close();
}
} finally {
context.close();
}
}
}
Loading