fix: resolve deprecated API usage in disk_blockdevice and storvsp#3069
Closed
benhillis wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix: resolve deprecated API usage in disk_blockdevice and storvsp#3069benhillis wants to merge 1 commit intomicrosoft:mainfrom
benhillis wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Member
benhillis
commented
Mar 19, 2026
benhillis
commented
- disk_blockdevice: Replace deprecated io_uring::types::RwFlags with i32 to match updated rw_flags() method signature
- storvsp: Replace deprecated try_next() with try_recv() on mpsc::Receiver
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates storage device code to match upstream API changes, removing deprecated usages so the affected crates continue to build cleanly against newer dependencies.
Changes:
disk_blockdevice: Replace deprecatedio_uring::types::RwFlagsusage with ani32flag value to match the updatedrw_flags()signature.storvsp: Replace deprecatedtry_next()on afutures::channel::mpsc::Receiverwithtry_recv().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vm/devices/storage/storvsp/src/lib.rs | Switches rescan notification drain call from deprecated try_next() to try_recv(). |
| vm/devices/storage/disk_blockdevice/src/lib.rs | Removes deprecated RwFlags import and updates RWF_DSYNC constant type to i32 for rw_flags(). |
benhillis
force-pushed
the
storage_clippy_issues
branch
from
851b8c1 to
87599ec
Compare
- disk_blockdevice: Replace deprecated io_uring::types::RwFlags with i32 to match updated rw_flags() method signature - storvsp: Replace deprecated try_next() with try_recv() on mpsc::Receiver
benhillis
force-pushed
the
storage_clippy_issues
branch
from
87599ec to
8937de7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.