Skip SetupDi device discovery if Win32k system calls are disabled#28535
Open
shiyi9801 wants to merge 3 commits into
Open
Skip SetupDi device discovery if Win32k system calls are disabled#28535shiyi9801 wants to merge 3 commits into
shiyi9801 wants to merge 3 commits into
Conversation
Contributor
Author
|
@skottmckay @fdwr Could you please take a look? thanks! |
fdwr
reviewed
May 18, 2026
Contributor
There was a problem hiding this comment.
There's some context missing from the description:
- Which process in Chrome is being executed here that disables win32k calls?
- Does it disable a subset of calls or all calls, deferring to other processes to all win32 calls?
Otherwise the change looks fine to me, except small naming.
Co-authored-by: Dwayne Robinson <fdwr@hotmail.com>
Contributor
Author
Updated the description, @fdwr please take another look, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skip SetupDi device discovery when Win32k system calls are disabled.
SetupDiGetClassDevsdepends on win32k.sys and will crash with an SEH exception that cannot be caught by C++ try/catch.Motivation and Context
WebNN is migrating ORT graph compilation to a sandboxed process with PROCESS_MITIGATION_SYSTEM_CALL_DISABLE_POLICY.DisallowWin32kSystemCalls enabled. This prevents kernel-mode system calls through win32k.sys for security hardening.
This change has no effect on normal (unsandboxed) processes.