Reserve WebGPU program vector capacity#28534
Open
Lingavasan wants to merge 1 commit into
Open
Conversation
Signed-off-by: Lingavasan <lsuresh4@asu.edu>
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28516
Summary
ProgramBasereserve helpers for inputs, outputs, and uniform variablesProgramBase&returnsValidation
git diff --checkPATH="$PWD/.venv/bin:$PATH" .venv/bin/lintrunner -a onnxruntime/core/providers/webgpu/program.h onnxruntime/core/providers/webgpu/program.cc onnxruntime/core/providers/webgpu/program_test.cc onnxruntime/core/providers/webgpu/nn/conv.cc onnxruntime/core/providers/webgpu/nn/conv2d_mm.ccPATH="$PWD/.venv/bin:$PATH" python3 tools/ci_build/build.py --build_dir /private/tmp/ort-webgpu-build --config Release --update --use_webgpu --cmake_path "$PWD/.venv/bin/cmake" --cmake_generator Ninja --skip_testsPATH="$PWD/.venv/bin:$PATH" .venv/bin/ninja -C /private/tmp/ort-webgpu-build/Release onnxruntime_providers_webgpuPATH="$PWD/.venv/bin:$PATH" .venv/bin/ninja -C /private/tmp/ort-webgpu-build/Release onnxruntime_test_all onnxruntime_provider_test onnx_test_runnerPATH="$PWD/.venv/bin:$PATH" .venv/bin/ctest --test-dir /private/tmp/ort-webgpu-build/Release --output-on-failureCTest note:
onnx_test_pytorch_convertedandonnx_test_pytorch_operatorpassed locally.onnxruntime_test_allandonnxruntime_provider_testbuilt successfully but abort on this local macOS environment because Dawn reportsFailed to get a WebGPU adapter: No supported adapterswhile initializing the WebGPU EP, before completing the suite.