Repository navigation
test(microvm): read the host-loopback HTTP request up to its blank line - #577
Open
Jay (jay23606) wants to merge 1 commit into
Open
Jay (jay23606) wants to merge 1 commit into
Jay (jay23606) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix addresses TCP fragmentation with regression coverage and no identified blocking issues.
0 open findings
What changed in this PR
Fixes #505 by allowing the host-loopback HTTP fixture to handle requests fragmented across TCP reads.
Changes:
- Accumulates requests until the header terminator, with a deadline and an 8 KiB size limit.
- Adds real loopback-socket tests for single-send and fragmented requests.
| File | Description |
|---|---|
| scripts/test_microvm_tests.py | Adds HTTP fixture regression tests. |
| scripts/nvx_tools/microvm_tests.py | Adds bounded request accumulation before validation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 15, 2026 21:50
ba7c1d9 to
35e299e
Compare
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 19, 2026 04:34
2360e7d to
1a47959
Compare
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 19, 2026 11:03
1a47959 to
ade1d55
Compare
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 19, 2026 12:55
ade1d55 to
253b1e6
Compare
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 19, 2026 13:11
253b1e6 to
9eaec4c
Compare
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 19, 2026 13:31
9eaec4c to
d74b91f
Compare
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 19, 2026 21:58
642b73e to
7d1dcb5
Compare
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 19, 2026 22:36
7d1dcb5 to
d6d9916
Compare
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 19, 2026 22:55
d6d9916 to
a8e6244
Compare
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 19, 2026 23:39
a8e6244 to
19be981
Compare
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 20, 2026 00:40
19be981 to
fa9d8b8
Compare
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 20, 2026 02:15
fa9d8b8 to
b340cbd
Compare
The fixture validated the first recv(4096) and rejected a valid request that TCP delivered in several reads. Read until the header terminator, within the timeout and a size cap. Add tests for a single send and a split request. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Signed-off-by: jay23606 <4602056+jay23606@users.noreply.github.com>
Jay (jay23606)
force-pushed
the
fix/host-loopback-http-fragments
branch
from
October 20, 2026 04:47
b340cbd to
a341239
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #505
Summary
recv(4096)and rejected a valid request that TCP delivered in several reads (for exampleGETthen the rest)._read_http_requestnow reads until the header terminator, within the configured timeout and an 8 KiB cap, then validates the full request.Test
HostLoopbackHttpFixtureTestsuses real loopback sockets. The split case fails ondev(WinError 10053) and passes with this change, as does the single-send control.test_microvm_testsruns the same 9 failures ondevand on this branch (the host-loopback publication and ingress scripts and the SMP timer test), so they are not from this change.🤖 Generated with Claude Code