Skip to content

Address PR 32 review comments#34

Open
Copilot wants to merge 2 commits into
mainfrom
copilot/address-comments-in-pr-32
Open

Address PR 32 review comments#34
Copilot wants to merge 2 commits into
mainfrom
copilot/address-comments-in-pr-32

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 5, 2026

Addresses review feedback on PR #32 around partial range validation, duplicated tree cleanup/move logic, and coverage test diagnostics.

  • Range validation

    • Simplifies partial serialization range checks into one ordered bounds expression:
      min_index() <= from && from <= to && to <= max_index()
  • Tree ownership cleanup

    • Extracts repeated TreeT teardown into clear().
    • Extracts move-transfer/reset behavior into move_from().
    • Reuses both helpers from move construction, move assignment, copy assignment cleanup, destruction, and deserialization reset paths.
  • Coverage diagnostics

    • Sends coverage test error output to stderr instead of stdout.

@achamayou
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jun 5, 2026

@copilot fix the clang tidy errors in https://github.com/microsoft/merklecpp/actions/runs/27033275945/job/79790938759?pr=34

Fixed in c182cd5. I also validated locally with the CI-style clang-tidy header check and tests.

@achamayou achamayou marked this pull request as ready for review June 5, 2026 18:57
Copilot AI review requested due to automatic review settings June 5, 2026 18:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants