Address PR 32 review comments#34
Open
Copilot wants to merge 2 commits into
Open
Conversation
Copilot created this pull request from a session on behalf of
achamayou
June 5, 2026 18:38
View session
Member
|
@copilot fix the clang tidy errors in https://github.com/microsoft/merklecpp/actions/runs/27033275945/job/79790938759?pr=34 |
Contributor
Author
Fixed in c182cd5. I also validated locally with the CI-style clang-tidy header check and tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on PR #32 around partial range validation, duplicated tree cleanup/move logic, and coverage test diagnostics.
Range validation
min_index() <= from && from <= to && to <= max_index()Tree ownership cleanup
TreeTteardown intoclear().move_from().Coverage diagnostics
stderrinstead ofstdout.