fix(ipynb): preserve JSON documents that mention notebook fields - #2473
Open
Oscar (Oscar-Williams) wants to merge 1 commit into
Open
fix(ipynb): preserve JSON documents that mention notebook fields#2473Oscar (Oscar-Williams) wants to merge 1 commit into
Oscar (Oscar-Williams) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ordinary JSON document such as
{"description": "nbformat_minor describes a notebook version"}currently converts to empty Markdown.IpynbConverter.accepts()matches notebook field names anywhere in the text, then conversion treats the missing cells as an empty notebook and prevents the plain-text fallback.Probe the parsed top-level JSON fields before accepting it as a notebook. Check JSON before trusting a
.ipynbextension, since format detection can infer that extension for JSON schema fragments too. Preserve BOM/charset handling and stream position, and decline malformed or excessively nested JSON without interrupting conversion.Validation on Windows, Python 3.11.7:
mainand 17 passed with this fix.hatch test --python 3.11 -q --tb=short: 859 passed, 34 skipped, using the project's CI skip mode (GITHUB_ACTIONS=true,PYTHONUTF8=1).pre-commit run --all-filesandgit diff --check: passed.Implemented and tested with Codex assistance.