[Draft] Dynamic TA Support - #1213

Process completed with exit code 1.

"cargo clippy" failed

error: this function has too many arguments (8/7) --> litebox_runner_lvbs/src/lib.rs:1419:1 | 1419 | / fn open_session_new_instance( 1420 | | platform: &'static Platform, 1421 | | msg_args: &mut OpteeMsgArgs, 1422 | | msg_args_phys_addr: u64, ... | 1427 | | ta_req_info: &litebox_shim_optee::msg_handler::TaRequestInfo<PAGE_SIZE>, 1428 | | ) -> Result<(), OpteeSmcReturnCode> { | |___________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `-D clippy::too-many-arguments` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`

error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> litebox_runner_lvbs/src/lib.rs:1026:5 | 1026 | / match rpc_args.is_param_tmem_output_noncontiguous(0) { 1027 | | Ok(true) => {} 1028 | | Ok(false) | Err(_) => { 1029 | | start_shm_free_rpc( ... | 1041 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else help: try | 1026 ~ if let Ok(true) = rpc_args.is_param_tmem_output_noncontiguous(0) {} else { 1027 + start_shm_free_rpc( 1028 + platform, 1029 + smc_args, 1030 + msg_args, 1031 + rpc_args, 1032 + context_id, 1033 + RpcStage::ShmAlloc, 1034 + tmem.shm_ref, 1035 + RpcCompletion::ReturnError(OpteeSmcReturnCode::ENotAvail), 1036 + ); 1037 + return; 1038 + } |

error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> litebox_runner_lvbs/src/lib.rs:1005:16 | 1005 | let tmem = match rpc_args.get_param_tmem_output(0) { | ________________^ 1006 | | Ok(tmem) => tmem, 1007 | | Err(_) => { 1008 | | discard_rpc_context(context_id); ... | 1012 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else help: try | 1005 ~ let tmem = if let Ok(tmem) = rpc_args.get_param_tmem_output(0) { tmem } else { 1006 + discard_rpc_context(context_id); 1007 + smc_args.set_return_code(OpteeSmcReturnCode::EBadCmd); 1008 + return; 1009 ~ }; |

error: this could be rewritten as `let...else` --> litebox_runner_lvbs/src/lib.rs:1005:5 | 1005 | / let tmem = match rpc_args.get_param_tmem_output(0) { 1006 | | Ok(tmem) => tmem, 1007 | | Err(_) => { 1008 | | discard_rpc_context(context_id); ... | 1012 | | }; | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_let_else help: consider writing | 1005 ~ let Ok(tmem) = rpc_args.get_param_tmem_output(0) else { 1006 + discard_rpc_context(context_id); 1007 + smc_args.set_return_code(OpteeSmcReturnCode::EBadCmd); 1008 + return; 1009 + }; |

error: unnecessary boolean `not` operation --> litebox_runner_lvbs/src/lib.rs:874:13 | 874 | / if !shim.store_ta_bin(&ta_uuid, &ta_binary) { 875 | | RpcCompletion::ReturnError(OpteeSmcReturnCode::EBadCmd) 876 | | } else { 877 | | RpcCompletion::OpenSession 878 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else = note: `-D clippy::if-not-else` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::if_not_else)]` help: try | 874 ~ if shim.store_ta_bin(&ta_uuid, &ta_binary) { 875 + RpcCompletion::OpenSession 876 + } else { 877 + RpcCompletion::ReturnError(OpteeSmcReturnCode::EBadCmd) 878 + } |

error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> litebox_runner_lvbs/src/lib.rs:647:35 | 647 | let ta_uuid = match decode_ta_request(platform, &msg_args) | ___________________________________^ 648 | | .ok() 649 | | .and_then(|request| request.uuid) ... | 656 | | }; | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else = note: `-D clippy::single-match-else` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_match_else)]` help: try | 647 ~ let ta_uuid = if let Some(ta_uuid) = decode_ta_request(platform, &msg_args) 648 + .ok() 649 + .and_then(|request| request.uuid) { ta_uuid } else { 650 + smc_args.set_return_code(OpteeSmcReturnCode::EBadCmd); 651 + return *smc_args; 652 ~ }; |