Skip to content

Upgrade and don't pin go infra images#2133

Open
qmuntal wants to merge 4 commits intomicrosoft/mainfrom
dev/qmuntal/upgrgoinfraimages
Open

Upgrade and don't pin go infra images#2133
qmuntal wants to merge 4 commits intomicrosoft/mainfrom
dev/qmuntal/upgrgoinfraimages

Conversation

@qmuntal
Copy link
Member

@qmuntal qmuntal commented Feb 12, 2026

No description provided.

@qmuntal qmuntal requested a review from a team as a code owner February 12, 2026 14:02
@dagood
Copy link
Member

dagood commented Feb 12, 2026

This also hits:

=== RUN   TestAllocatonsWithTypeAsserts
    sha256_test.go:503: allocs = 9; want <= 2
--- FAIL: TestAllocatonsWithTypeAsserts (0.00s)

The test panel is pretty bad when there are multiple attempts--nothing distinguishes the two other than manually checking if the logs make sense for which tests failed:

image

@dagood
Copy link
Member

dagood commented Feb 13, 2026

In the interest of unblocking clean CI for the release and all main PRs, we can fix that later.

@qmuntal
Copy link
Member Author

qmuntal commented Feb 13, 2026

Will upgrade the OpenSSL module in this PR to try to fix the allocations (it should be fixed by golang-fips/openssl#369)

@qmuntal qmuntal force-pushed the dev/qmuntal/upgrgoinfraimages branch from a451166 to 8ab8559 Compare February 13, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants