fix(web-components): keep switch indicator visible in forced-colors mode - #36742
Open
megumiimai wants to merge 1 commit into
Open
megumiimai wants to merge 1 commit into
megumiimai wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
In forced-colors mode (Windows High Contrast), the
fluent-switchindicator usedActiveCaption(deprecated, resolves toCanvas) when unchecked andButtonFacewhen checked. On dark themes the unchecked indicator rendered the same color as the background and was invisible.New Behavior
The indicator now uses
CanvasTextwhen unchecked andHighlightTextwhen checked. Both are paired system colors with guaranteed contrast againstCanvasandHighlightrespectively, so the thumb stays visible in both light and dark forced-colors themes. This matches theCanvasTextusage in the v9 React Switch.Related Issue(s)
Fixes #36676