Skip to content

fix(react-dialog): enable keyboard scrolling in long content story #36736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Moura (Rodrigorm33) wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix(react-dialog): enable keyboard scrolling in long content story #36736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...s/react-components/react-dialog/stories/src/Dialog/DialogScrollingLongContent.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const ScrollingLongContent = (): JSXElement => {
<DialogSurface>
<DialogBody>
<DialogTitle>Dialog title</DialogTitle>
<DialogContent>
<DialogContent tabIndex={0}>
<p>
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et
dolore magna aliqua. Nisl pretium fusce id velit ut tortor. Leo vel fringilla est ullamcorper. Eget est
Expand Down Expand Up @@ -142,7 +142,7 @@ ScrollingLongContent.parameters = {
docs: {
description: {
story:
'By default `DialogContent` should grow until it fits viewport size, overflowed content will be scrollable',
'By default `DialogContent` should grow until it fits viewport size, overflowed content will be scrollable. When the content has no focusable elements, set `tabIndex={0}` on `DialogContent` to enable keyboard scrolling.',
},
},
};